From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jiang Jian <jiangjian@cdjrlc.com>
Cc: jic23@kernel.org, lars@metafoo.de, ardeleanalex@gmail.com,
antoniu.miclaus@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio:magnetometer:hmc5843: Remove duplicate 'the' in two places.
Date: Tue, 21 Jun 2022 23:11:26 +0200 [thread overview]
Message-ID: <20220621211126.q4crb44djniriqo7@pengutronix.de> (raw)
In-Reply-To: <20220621164056.30622-1-jiangjian@cdjrlc.com>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Wed, Jun 22, 2022 at 12:40:56AM +0800, Jiang Jian wrote:
> file: drivers/iio/magnetometer/hmc5843_core.c
> line: 3
> * Device driver for the the HMC5843 multi-chip module designed
> changed to
> * Device driver for the HMC5843 multi-chip module designed
>
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
The patch looks good, the commit log however is bad and wrong. There
are no "two places". I'd just write:
iio:magnetometer:hmc5843: Remove duplicate 'the'
Fix an obvious typing error, found by spellcheck(1).
Signed-off-....
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-06-21 21:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:40 Jiang Jian
2022-06-21 21:11 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621211126.q4crb44djniriqo7@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=antoniu.miclaus@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=jiangjian@cdjrlc.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®