From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<martin.petersen@oracle.com>, <avri.altman@wdc.com>,
<alim.akhtar@samsung.com>, <jejb@linux.ibm.com>,
<bvanassche@acm.org>
Cc: <peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
<alice.chao@mediatek.com>, <powen.kao@mediatek.com>,
<mason.zhang@mediatek.com>, <qilin.tan@mediatek.com>,
<lin.gui@mediatek.com>, <eddie.huang@mediatek.com>,
<tun-yu.yu@mediatek.com>, <cc.chou@mediatek.com>,
<chaotian.jing@mediatek.com>, <jiajie.hao@mediatek.com>,
<stanley.chu@mediatek.com>
Subject: [PATCH v2 8/8] scsi: ufs-mediatek: Fix invalid access to vccqx
Date: Thu, 23 Jun 2022 11:50:52 +0800 [thread overview]
Message-ID: <20220623035052.18802-9-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20220623035052.18802-1-stanley.chu@mediatek.com>
From: Alice Chao <alice.chao@mediatek.com>
NULL pointer access issue was found for the regulator released
by ufs_mtk_vreg_fix_vccq(). Simply fix this issue by clearing
the released vreg pointer in ufs_hba struct.
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Alice Chao <alice.chao@mediatek.com>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
drivers/ufs/host/ufs-mediatek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 125d64e097f2..2404df9c3a01 100755
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -758,6 +758,7 @@ static void ufs_mtk_vreg_fix_vccqx(struct ufs_hba *hba)
regulator_disable((*vreg_off)->reg);
devm_kfree(hba->dev, (*vreg_off)->name);
devm_kfree(hba->dev, *vreg_off);
+ *vreg_off = NULL;
}
}
--
2.18.0
next prev parent reply other threads:[~2022-06-23 4:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 3:50 [PATCH v2 0/8] Provide features and fixes in MediaTek UFS platform Stanley Chu
2022-06-23 3:50 ` [PATCH v2 1/8] scsi: ufs-mediatek: Fix build warnings Stanley Chu
2022-06-23 3:50 ` [PATCH v2 2/8] scsi: ufs-mediatek: Always add delays for VCC operations Stanley Chu
2022-06-23 3:50 ` [PATCH v2 3/8] scsi: ufs-mediatek: Prevent host hang by setting CLK_CG early Stanley Chu
2022-06-23 3:50 ` [PATCH v2 4/8] scsi: ufs-mediatek: Add stage information for ref-clk control Stanley Chu
2022-06-23 3:50 ` [PATCH v2 5/8] scsi: ufs-mediatek: Disable reset confirm feature by UniPro Stanley Chu
2022-06-23 3:50 ` [PATCH v2 6/8] scsi: ufs-mediatek: Support host power control Stanley Chu
2022-06-23 3:50 ` [PATCH v2 7/8] scsi: ufs-mediatek: Support performance boosting Stanley Chu
2022-06-23 3:50 ` Stanley Chu [this message]
2022-06-23 13:15 ` [PATCH v2 0/8] Provide features and fixes in MediaTek UFS platform Bart Van Assche
2022-06-28 3:18 ` Martin K. Petersen
2022-07-07 21:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623035052.18802-9-stanley.chu@mediatek.com \
--to=stanley.chu@mediatek.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mason.zhang@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=tun-yu.yu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®