From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Felix Schlepper <f3sch.git@outlook.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling
Date: Fri, 24 Jun 2022 08:21:18 +0300 [thread overview]
Message-ID: <20220624052118.GT16517@kadam> (raw)
In-Reply-To: <CAHp75VcQcKaYUP_JsmTFOY-pbOR39+TMw=5ADbb2BRGoMijCMw@mail.gmail.com>
On Thu, Jun 23, 2022 at 11:20:49PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper <f3sch.git@outlook.com> wrote:
> >
> > Moved error handling to one common block.
> > This removes double checking if all txb->fragments[]
> > were initialized.
> > The original code worked fine, but this is cleaner.
>
> ...
>
> > +err_free:
> > + while (--i >= 0)
>
> while (i--)
>
> will suffice.
>
Either one is fine. You prefer this format. I prefer that other
format. I told Felix he could use either format without expressing any
bias and he chose my format. That means he loves me more.
regards,
dan carpenter
next prev parent reply other threads:[~2022-06-24 5:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 20:27 [PATCH v4 0/3] Staging: rtl8192e: Safer allocation and cleaner " Felix Schlepper
2022-06-23 10:05 ` [PATCH v4 1/3] Staging: rtl8192e: Use struct_size Felix Schlepper
2022-06-23 10:05 ` [PATCH v4 2/3] Staging: rtl8192e: Using kzalloc and delete memset Felix Schlepper
2022-06-23 10:05 ` [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling Felix Schlepper
2022-06-23 20:27 ` [PATCH v4 1/3] Staging: rtl8192e: Use struct_size Felix Schlepper
2022-06-23 20:27 ` [PATCH v4 2/3] Staging: rtl8192e: Using kzalloc and delete memset Felix Schlepper
2022-06-23 20:27 ` [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling Felix Schlepper
2022-06-23 21:20 ` Andy Shevchenko
2022-06-24 5:21 ` Dan Carpenter [this message]
2022-06-24 8:41 ` Felix Schlepper
2022-06-24 11:32 ` Greg Kroah-Hartman
[not found] <AM9P190MB12995A5916BDAE3F2A8222CCA5B59@AM9P190MB1299.EURP190.PROD.OUTLOOK.COM>
2022-06-23 13:28 ` Felix Schlepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624052118.GT16517@kadam \
--to=dan.carpenter@oracle.com \
--cc=andy.shevchenko@gmail.com \
--cc=f3sch.git@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome