From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
dri-devel@lists.freedesktop.org
Cc: mhocko@suse.com, "Christian König" <christian.koenig@amd.com>
Subject: [PATCH 03/14] proc: expose per file RSS
Date: Fri, 24 Jun 2022 10:04:33 +0200 [thread overview]
Message-ID: <20220624080444.7619-4-christian.koenig@amd.com> (raw)
In-Reply-To: <20220624080444.7619-1-christian.koenig@amd.com>
Add the per file RSS to the memory management accounting.
This allows to see the per file RSS in tools like top as well.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
fs/proc/array.c | 7 +++++--
fs/proc/internal.h | 3 ++-
fs/proc/task_mmu.c | 6 ++++--
fs/proc/task_nommu.c | 3 ++-
4 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/fs/proc/array.c b/fs/proc/array.c
index eb815759842c..a3aabe4ac7c8 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -437,7 +437,7 @@ int proc_pid_status(struct seq_file *m, struct pid_namespace *ns,
task_state(m, ns, pid, task);
if (mm) {
- task_mem(m, mm);
+ task_mem(m, mm, task->files);
task_core_dumping(m, task);
task_thp_status(m, mm);
mmput(mm);
@@ -589,7 +589,8 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
seq_put_decimal_ull(m, " ", 0);
seq_put_decimal_ull(m, " ", start_time);
seq_put_decimal_ull(m, " ", vsize);
- seq_put_decimal_ull(m, " ", mm ? get_mm_rss(mm) : 0);
+ seq_put_decimal_ull(m, " ", (mm ? get_mm_rss(mm) : 0) +
+ files_rss(task->files));
seq_put_decimal_ull(m, " ", rsslim);
seq_put_decimal_ull(m, " ", mm ? (permitted ? mm->start_code : 1) : 0);
seq_put_decimal_ull(m, " ", mm ? (permitted ? mm->end_code : 1) : 0);
@@ -673,6 +674,8 @@ int proc_pid_statm(struct seq_file *m, struct pid_namespace *ns,
size = task_statm(mm, &shared, &text, &data, &resident);
mmput(mm);
+ shared += files_rss(task->files);
+
/*
* For quick read, open code by putting numbers directly
* expected format is
diff --git a/fs/proc/internal.h b/fs/proc/internal.h
index 06a80f78433d..1b123893f7ae 100644
--- a/fs/proc/internal.h
+++ b/fs/proc/internal.h
@@ -305,7 +305,8 @@ extern unsigned long task_vsize(struct mm_struct *);
extern unsigned long task_statm(struct mm_struct *,
unsigned long *, unsigned long *,
unsigned long *, unsigned long *);
-extern void task_mem(struct seq_file *, struct mm_struct *);
+extern void task_mem(struct seq_file *, struct mm_struct *,
+ struct files_struct *);
extern const struct dentry_operations proc_net_dentry_ops;
static inline void pde_force_lookup(struct proc_dir_entry *pde)
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 2d04e3470d4c..a4adc6fc13d3 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -20,6 +20,7 @@
#include <linux/shmem_fs.h>
#include <linux/uaccess.h>
#include <linux/pkeys.h>
+#include <linux/fdtable.h>
#include <asm/elf.h>
#include <asm/tlb.h>
@@ -28,13 +29,14 @@
#define SEQ_PUT_DEC(str, val) \
seq_put_decimal_ull_width(m, str, (val) << (PAGE_SHIFT-10), 8)
-void task_mem(struct seq_file *m, struct mm_struct *mm)
+void task_mem(struct seq_file *m, struct mm_struct *mm,
+ struct files_struct *files)
{
unsigned long text, lib, swap, anon, file, shmem;
unsigned long hiwater_vm, total_vm, hiwater_rss, total_rss;
anon = get_mm_counter(mm, MM_ANONPAGES);
- file = get_mm_counter(mm, MM_FILEPAGES);
+ file = get_mm_counter(mm, MM_FILEPAGES) + files_rss(files);
shmem = get_mm_counter(mm, MM_SHMEMPAGES);
/*
diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
index a6d21fc0033c..5b6b9c5ed9ec 100644
--- a/fs/proc/task_nommu.c
+++ b/fs/proc/task_nommu.c
@@ -18,7 +18,8 @@
* each process that owns it. Non-shared memory is counted
* accurately.
*/
-void task_mem(struct seq_file *m, struct mm_struct *mm)
+void task_mem(struct seq_file *m, struct mm_struct *mm,
+ struct files_struct *files)
{
struct vm_area_struct *vma;
struct vm_region *region;
--
2.25.1
next prev parent reply other threads:[~2022-06-24 8:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 8:04 [RFC] Per file OOM-badness / RSS once more Christian König
2022-06-24 8:04 ` [PATCH 01/14] fs: add per file RSS Christian König
2022-06-24 8:04 ` [PATCH 02/14] oom: take per file RSS into account Christian König
2022-06-24 8:04 ` Christian König [this message]
2022-06-24 8:04 ` [PATCH 04/14] mm: shmem: provide RSS for shmem files Christian König
2022-06-24 8:04 ` [PATCH 05/14] dma-buf: provide file RSS for DMA-buf files Christian König
2022-06-24 8:04 ` [PATCH 06/14] drm/gem: adjust per file RSS on handling buffers Christian König
2022-06-24 8:04 ` [PATCH 07/14] drm/gma500: use drm_file_rss Christian König
2022-06-24 8:04 ` [PATCH 08/14] drm/amdgpu: " Christian König
2022-06-24 8:04 ` [PATCH 09/14] drm/radeon: use drm_oom_badness Christian König
2022-06-28 10:34 ` Michel Dänzer
2022-06-24 8:04 ` [PATCH 10/14] drm/i915: use drm_file_rss Christian König
2022-06-24 8:04 ` [PATCH 11/14] drm/nouveau: " Christian König
2022-06-24 8:04 ` [PATCH 12/14] drm/omap: " Christian König
2022-06-24 8:04 ` [PATCH 13/14] drm/vmwgfx: " Christian König
2022-06-24 8:04 ` [PATCH 14/14] drm/tegra: " Christian König
2022-06-24 9:59 ` [RFC] Per file OOM-badness / RSS once more Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624080444.7619-4-christian.koenig@amd.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®