From: Stephen Kitt <steve@sk2.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Dianlong Li <long17.cool@163.com>, Wolfram Sang <wsa@kernel.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: use simple i2c probe
Date: Fri, 24 Jun 2022 23:05:25 +0200 [thread overview]
Message-ID: <20220624230525.0b78a0e9@heffalump.sk2.org> (raw)
In-Reply-To: <YrX3mWxDex7OuEpn@mail.local>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Fri, 24 Jun 2022 19:42:49 +0200, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 12/06/2022 21:23:47+0200, Stephen Kitt wrote:
> > Do you have an example of a change requiring id to support RTCs on x86
> > systems?
>
> I checked and your patch is actually fine, the issue I referred to is:
>
> 1c1b3098ae1e ("rtc: pcf85063: add i2c_device_id name matching support")
Ah yes, I see! The changes I’m making are compatible with that (as you
figured out), I’m not removing the id tables, just avoiding calls to
i2c_match_id when they’re not needed. In fact the approach I use for drivers
which do need their id tables is the same as in the commit above, with an
explicit call to i2c_match_id instead of the old-style probe.
Regards,
Stephen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-24 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 16:23 Stephen Kitt
2022-06-11 14:48 ` Alexandre Belloni
2022-06-12 19:23 ` Stephen Kitt
2022-06-24 17:42 ` Alexandre Belloni
2022-06-24 21:05 ` Stephen Kitt [this message]
2022-06-24 17:40 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624230525.0b78a0e9@heffalump.sk2.org \
--to=steve@sk2.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=long17.cool@163.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®