mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Subject: [rmk-arm:clearfog 8/9] drivers/pci/pcie/portdrv_core.c:330 pcie_port_device_register() warn: inconsistent indenting
Date: Sat, 25 Jun 2022 17:15:49 +0800	[thread overview]
Message-ID: <202206251737.5U9GIY6w-lkp@intel.com> (raw)

tree:   git://git.armlinux.org.uk/~rmk/linux-arm clearfog
head:   7fbb8b943f85ac20627571eb927cadfae176a4f7
commit: e86a7c1bfd62bfa0fb3c5319b651c192df44337d [8/9] mvebu/clearfog pcie updates
config: i386-randconfig-m021
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
drivers/pci/pcie/portdrv_core.c:330 pcie_port_device_register() warn: inconsistent indenting

Old smatch warnings:
drivers/pci/pcie/portdrv_core.c:343 pcie_port_device_register() warn: inconsistent indenting

vim +330 drivers/pci/pcie/portdrv_core.c

   310	
   311	/**
   312	 * pcie_port_device_register - register PCI Express port
   313	 * @dev: PCI Express port to register
   314	 *
   315	 * Allocate the port extension structure and register services associated with
   316	 * the port.
   317	 */
   318	int pcie_port_device_register(struct pci_dev *dev)
   319	{
   320		int status, capabilities, i, nr_service;
   321		int irqs[PCIE_PORT_DEVICE_MAXSERVICES];
   322	
   323		/* Enable PCI Express port device */
   324		status = pci_enable_device(dev);
   325		if (status)
   326			return status;
   327	
   328		/* Get and check PCI Express port services */
   329		capabilities = get_port_device_capability(dev);
 > 330	dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
   331		if (!capabilities)
   332			return 0;
   333	
   334		pci_set_master(dev);
   335		/*
   336		 * Initialize service irqs. Don't use service devices that
   337		 * require interrupts if there is no way to generate them.
   338		 * However, some drivers may have a polling mode (e.g. pciehp_poll_mode)
   339		 * that can be used in the absence of irqs.  Allow them to determine
   340		 * if that is to be used.
   341		 */
   342		status = pcie_init_service_irqs(dev, irqs, capabilities);
   343	dev_info(&dev->dev, "init_service_irqs: %d\n", status);
   344		if (status) {
   345			capabilities &= PCIE_PORT_SERVICE_HP;
   346			if (!capabilities)
   347				goto error_disable;
   348		}
   349	
   350		/* Allocate child services if any */
   351		status = -ENODEV;
   352		nr_service = 0;
   353		for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
   354			int service = 1 << i;
   355			if (!(capabilities & service))
   356				continue;
   357			if (!pcie_device_init(dev, service, irqs[i]))
   358				nr_service++;
   359		}
   360		if (!nr_service)
   361			goto error_cleanup_irqs;
   362	
   363		return 0;
   364	
   365	error_cleanup_irqs:
   366		pci_free_irq_vectors(dev);
   367	error_disable:
   368		pci_disable_device(dev);
   369		return status;
   370	}
   371	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-06-25  9:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25  9:15 kernel test robot [this message]
2022-08-04  5:56 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206251737.5U9GIY6w-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®