From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41033C433EF for ; Sat, 25 Jun 2022 23:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233652AbiFYX7M (ORCPT ); Sat, 25 Jun 2022 19:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231234AbiFYX7J (ORCPT ); Sat, 25 Jun 2022 19:59:09 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8585D13DF3 for ; Sat, 25 Jun 2022 16:59:07 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id c1so9917457qvi.11 for ; Sat, 25 Jun 2022 16:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OIkvZSCfU1CjrPejBudrIGntnY32egXHLdKIcmmN0pg=; b=duH504ulYOnzBaVTLyLo1maWRZER3UvuJOkl8g0W5A7EYWwmU7JLyVVOeVm/mzY6jz wEQqHqotXWBM9p2+EAvrZPlBnGf0wIXCNnyoHFxr5zjGsKVcLPXHkfQVwIGTrVZFfHJg E4e8lZiIn8rsAZTGPhWBTHBxWkOp5DngPB1Az8BgpizpK4wZTN68kKTCIq1n4SCn6Y5V 56K05ugA1OyB3vJpg7045S8yLgufcX3ypvS9ZGEs793kJzwt2Pp/5EpQpLRLJ0SmkWOO 9J5MhDH6Dt3+awMXHKsUxbuCGMHLj/OPr3AwVMHf2ZWmG4UVE5Y1CWHYNDj00yZt0DW0 kIiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OIkvZSCfU1CjrPejBudrIGntnY32egXHLdKIcmmN0pg=; b=xh3SGDIof93z/dkPKavtQCSKTOg2pgU9TVOxRVHVFETFKbSFBgidf5/nYqN3oUbPsP j/XFSO5Mzq1OrAr2B+McGeSSW1BgWEMxctSWpsrnOc3/UCNwtq8M4TfcKn9k/yq/bNm6 dwB1ZhDwgeGA8UvXsoddjLopSvAylWi6xyJ4YjlruOBpD3lS+76aQcu3sfCYA6Im8tVo pHfGTRe/IgEGKT6NZzcqKVxxgaqOiKACuoL3BqsyBMhJJhDl86kW0T9bRKU99yNQ+tfm 1Fnc9lLXCCxIaD6zhgHLBUVJxrgNpoy30eX2M4hM9XuGi1fYQAZVHdlj+A5GQqcUbN/E Y4wA== X-Gm-Message-State: AJIora+KGjUeUvna+Gmx8QkwMZvXDK65YQkQ+aqCwi5sVJ2UJ+jHEpLU Cf4k1Z64bNm6K3nki9mxGhx+9Q== X-Google-Smtp-Source: AGRyM1vkSR+fkkuzlMpkZs/yPAV/CYQBTRY/CutcwMiNTqboWAwrJeP6fXDvYF6KEeySkwQaI+gI6w== X-Received: by 2002:a05:622a:13c8:b0:317:7862:6b45 with SMTP id p8-20020a05622a13c800b0031778626b45mr4688676qtk.266.1656201546699; Sat, 25 Jun 2022 16:59:06 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id l2-20020a05620a28c200b006a6cadd89efsm5717888qkp.82.2022.06.25.16.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jun 2022 16:59:05 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1o5Fg8-001ry7-9l; Sat, 25 Jun 2022 20:59:04 -0300 Date: Sat, 25 Jun 2022 20:59:04 -0300 From: Jason Gunthorpe To: Peter Xu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: <20220625235904.GK23621@ziepe.ca> References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-2-peterx@redhat.com> <20220625003554.GJ23621@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2022 at 09:23:04PM -0400, Peter Xu wrote: > If to go back to the original question with a shorter answer: if the ioctl > context that GUP upon a page that will never be with a uffd context, then > it's probably not gonna help at all.. at least not before we use > FAULT_FLAG_INTERRUPTIBLE outside uffd page fault handling. I think I would be more interested in this if it could abort a swap in, for instance. Doesn't this happen if it flows the interruptible flag into the VMA's fault handler? Jason