mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	Nick Terrell <terrelln@fb.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ira Weiny <ira.weiny@intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>,
	John David Anglin <dave.anglin@bell.net>,
	linux-parisc@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [RESEND PATCH v4 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *"
Date: Mon, 27 Jun 2022 11:19:27 -0700	[thread overview]
Message-ID: <20220627111927.3ef94745aab4491901d43028@linux-foundation.org> (raw)
In-Reply-To: <2192593.iZASKD2KPV@opensuse>

On Mon, 27 Jun 2022 19:02:31 +0200 "Fabio M. De Francesco" <fmdefrancesco@gmail.com> wrote:

> > v1->v2: Change the commit message to clearly explain why these functions
> >         should require pointers to const void. The fundamental argument
> >         behind the commit message changes is semantic correctness.
> >         Obviously, there are no changes to the code.
> >         Many thanks to David Sterba and Ira Weiny for suggestions and
> >         reviews.
> >
> >  arch/parisc/include/asm/cacheflush.h |  6 +++---
> >  arch/parisc/kernel/cache.c           |  2 +-
> >  include/linux/highmem-internal.h     | 10 +++++-----
> >  mm/highmem.c                         |  2 +-
> >  4 files changed, 10 insertions(+), 10 deletions(-)
> 
> @Andrew:
> 
> Ira Weiny asked David Sterba for taking this patch through his tree because 
> it is a pre-requisite for a patch to fs/btrfs. He agreed with the above-
> mentioned suggestion, however I suppose that an ACK by you is needed.
> 
> Can you please take a look at this patch and say what you think about it?

Looks OK to me.  It's one of those "if it compiles, it's good" things.

I don't believe the patch has ever appeared on linux-mm?  Please send
it there for some review then go ahead and merge it up.


  reply	other threads:[~2022-06-27 18:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 21:00 [RESEND PATCH v4 0/2] btrfs: Replace kmap() with kmap_local_page() in zstd.c Fabio M. De Francesco
2022-06-16 21:00 ` [RESEND PATCH v4 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *" Fabio M. De Francesco
2022-06-27 17:02   ` Fabio M. De Francesco
2022-06-27 18:19     ` Andrew Morton [this message]
2022-06-28 14:46       ` Fabio M. De Francesco
2022-07-01 17:08         ` Ira Weiny
2022-06-16 21:00 ` [RESEND PATCH v4 2/2] btrfs: Replace kmap() with kmap_local_page() in zstd.c Fabio M. De Francesco
2022-07-01 17:19   ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220627111927.3ef94745aab4491901d43028@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bigeasy@linutronix.de \
    --cc=clm@fb.com \
    --cc=dave.anglin@bell.net \
    --cc=deller@gmx.de \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=fmdefrancesco@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=josef@toxicpanda.com \
    --cc=keescook@chromium.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=terrelln@fb.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®