From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A4AC43334 for ; Mon, 27 Jun 2022 16:23:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239272AbiF0QX2 (ORCPT ); Mon, 27 Jun 2022 12:23:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236443AbiF0QXZ (ORCPT ); Mon, 27 Jun 2022 12:23:25 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0C081A44A for ; Mon, 27 Jun 2022 09:23:24 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 060381758; Mon, 27 Jun 2022 09:23:24 -0700 (PDT) Received: from bogus (unknown [10.57.39.193]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 106C03F66F; Mon, 27 Jun 2022 09:23:21 -0700 (PDT) Date: Mon, 27 Jun 2022 17:22:11 +0100 From: Sudeep Holla To: Ionela Voinescu Cc: linux-kernel@vger.kernel.org, Greg KH , Atish Patra , Atish Patra , Vincent Guittot , Dietmar Eggemann , Qing Wang , Rob Herring , "Rafael J . Wysocki" , Pierre Gondois , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 00/20] arch_topology: Updates to add socket support and fix cluster ids Message-ID: <20220627162211.t2dlu2no2turnc6r@bogus> References: <20220621192034.3332546-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2022 at 02:54:28PM +0100, Ionela Voinescu wrote: > Hi Sudeep, > > On Tuesday 21 Jun 2022 at 20:20:14 (+0100), Sudeep Holla wrote: > > Hi All, > > > > This version updates cacheinfo to populate and use the information from > > there for all the cache topology. > > > > This series intends to fix some discrepancies we have in the CPU topology > > parsing from the device tree /cpu-map node. Also this diverges from the > > behaviour on a ACPI enabled platform. The expectation is that both DT > > and ACPI enabled systems must present consistent view of the CPU topology. > > > > Currently we assign generated cluster count as the physical package identifier > > for each CPU which is wrong. The device tree bindings for CPU topology supports > > sockets to infer the socket or physical package identifier for a given CPU. > > Also we don't check if all the cores/threads belong to the same cluster before > > updating their sibling masks which is fine as we don't set the cluster id yet. > > > > These changes also assigns the cluster identifier as parsed from the device tree > > cluster nodes within /cpu-map without support for nesting of the clusters. > > Finally, it also add support for socket nodes in /cpu-map. With this the > > parsing of exact same information from ACPI PPTT and /cpu-map DT node > > aligns well. > > > > The only exception is that the last level cache id information can be > > inferred from the same ACPI PPTT while we need to parse CPU cache nodes > > in the device tree. > > > > Hi Greg, > > > > I had not cc-ed you on earlier 3 versions as we had some disagreement > > amongst Arm developers which we have not settled. Let me know how you want to > > s/not/now :) > > > merge this once you agree with the changes. I can set pull request if > > you prefer. Let me know. > > > > v4[3]->v4: > > - Updated ACPI PPTT fw_token to use table offset instead of virtual > > address as it could get changed for everytime it is mapped before > > the global acpi_permanent_mmap is set > > - Added warning for the topology with nested clusters > > - Added update to cpu_clustergroup_mask so that introduction of > > correct cluster_id doesn't break existing platforms by limiting > > the span of clustergroup_mask(by Ionela) > > > > I've tested v4 on quite a few platforms: > - DT: Juno R0, DB845c, RB5 > - ACPI: TX2, Ampere Altra, Kunpeng920 > > and it all looks good from my point of view (topology and sched domain > hierarchy). > > So for the full set (after the changes requested for 16/20 and 20/20): > > Tested-by: Ionela Voinescu > Thanks for all the review and testing. Much appreciated! -- Regards, Sudeep