From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDBAC433EF for ; Mon, 27 Jun 2022 22:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242729AbiF0WgN (ORCPT ); Mon, 27 Jun 2022 18:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242691AbiF0WgL (ORCPT ); Mon, 27 Jun 2022 18:36:11 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60C93205EE for ; Mon, 27 Jun 2022 15:36:08 -0700 (PDT) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id B36953F812; Tue, 28 Jun 2022 00:36:05 +0200 (CEST) Date: Tue, 28 Jun 2022 00:36:03 +0200 From: Marijn Suijten To: Stephen Boyd Cc: Dmitry Baryshkov , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Michael Turquette , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rajeev Nandan , Vladimir Lypak , Arnd Bergmann , Jonathan Marek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw() Message-ID: <20220627223603.5dxxbqqqjddkgdnb@SoMainline.org> References: <20220601220747.1145095-1-marijn.suijten@somainline.org> <20220601220747.1145095-4-marijn.suijten@somainline.org> <20220609221211.684C1C34114@smtp.kernel.org> <20220610074632.abtec5kulbclund4@SoMainline.org> <20220610190112.1352DC34114@smtp.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610190112.1352DC34114@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-06-10 12:01:10, Stephen Boyd wrote: > Quoting Marijn Suijten (2022-06-10 00:46:32) > > On 2022-06-09 15:12:09, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > > > wrote: > > > > > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c > > > > > index 54942d758ee6..fabb98d0cdb2 100644 > > > > > --- a/drivers/clk/clk-fixed-factor.c > > > > > +++ b/drivers/clk/clk-fixed-factor.c > > > > > @@ -148,17 +151,50 @@ struct clk_hw *devm_clk_hw_register_fixed_factor_index(struct device *dev, > > > > > const char *name, unsigned int index, unsigned long flags, > > > > > unsigned int mult, unsigned int div) > > > > > { > > > > > - return __clk_hw_register_fixed_factor(dev, NULL, name, NULL, index, > > > > > - flags, mult, div, true); > > > > > + return __clk_hw_register_fixed_factor(dev, NULL, name, NULL, NULL, > > > > > + index, flags, mult, div, true); > > > > > > > > Here (and several times later) you are inserting an argument and then > > > > moving arguments to the next line. My slight preference would be to > > > > just insert the arg (and maybe break the line if it gets too long) w/o > > > > touching the next lines. > > > > That'll definitely look odd, as we'll end up with index floating on a > > single line, all on its own. > > Pretty sure Dmitry is suggesting to make the line longer, not put the > index on a line by itself. Ignore the 80-column limit. There's a "(and maybe break the line if it gets too long)" in there, but it's ugly especially for short (ie. "0,") arguments. I'm following your request to ignore 80-columns as a limit. Will resend this after being able to physically build-test it tomorrow, thanks! - Marijn