From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56F9C43334 for ; Tue, 28 Jun 2022 02:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243709AbiF1CVX (ORCPT ); Mon, 27 Jun 2022 22:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243567AbiF1CUb (ORCPT ); Mon, 27 Jun 2022 22:20:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6866E24BD1; Mon, 27 Jun 2022 19:20:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 01EB361838; Tue, 28 Jun 2022 02:20:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41ED0C341CF; Tue, 28 Jun 2022 02:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656382813; bh=Ak/QMYgWMPk9z84H6YTl/dkHXnydIElkUJmtMKIW2Dw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CITKAKSs6V1vMUJRxPcpunkI3ploY719MvVFxkhxINpjPlDRh4q/gQ9zufoP+wv1V TicQf9bL4IPk/5vfnATfXOGqn3KS0c3f8R/aAplAhMaI7hCEJKJssf8oSCWHirAN4N RS1Z4zeKWFtW8eLcI171mTGGsgwIasgLlNZCOXeVdtsgyGB/SxCWz91TYVaRaQY2Zl n7kiXN1b6xl6jMU+mc3jne+5cAGl/yTZ9eDQlCvEzzN8AQnq2KiBnGoqitzaiAcHB1 j+QdN79WWDWx6EUFCsy4+OJ66Ccy/VepT8eZ+3mTY+/6bWLkyz/zD5xE4l/G2P69XF hyRqSP80//bdQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hyunwoo Kim , Helge Deller , Sasha Levin , cai.huoqing@linux.dev, yang.lee@linux.alibaba.com, yangyingliang@huawei.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.18 33/53] video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write Date: Mon, 27 Jun 2022 22:18:19 -0400 Message-Id: <20220628021839.594423-33-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628021839.594423-1-sashal@kernel.org> References: <20220628021839.594423-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hyunwoo Kim [ Upstream commit a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7 ] In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of type int. Then, copy_from_user() may cause a heap overflow because it is used as the third argument of copy_from_user(). Signed-off-by: Hyunwoo Kim Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/pxa3xx-gcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 043cc8f9ef1c..c3cd1e1cc01b 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff, struct pxa3xx_gcu_batch *buffer; struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file); - int words = count / 4; + size_t words = count / 4; /* Does not need to be atomic. There's a lock in user space, * but anyhow, this is just for statistics. */ -- 2.35.1