From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 811F5CCA489 for ; Tue, 28 Jun 2022 02:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243620AbiF1CVc (ORCPT ); Mon, 27 Jun 2022 22:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243582AbiF1CUl (ORCPT ); Mon, 27 Jun 2022 22:20:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5980F24BE1; Mon, 27 Jun 2022 19:20:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 04C62B81C00; Tue, 28 Jun 2022 02:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D90E2C34115; Tue, 28 Jun 2022 02:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656382814; bh=E5NbZEQRq3XuusaBccycvE/L7K9nPCPxZRO2UdOKn1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dyMgKr8Z8In06RfEHWNkTssjbG3OEPErAOGBJCsQuRyolvfubGeHrukI0m5RqXcJm s+mXPEmW80+u5kh+KsX1036ndBJbQ7ZTAspi/zpRgSz58T7p0V/Zy9DUVxS5cV0pjy QjaNe+MqIUJ8Dzlzp5ZXAUq9T/5wF8WYpqTb+rjSO4MGA8ZzUU3L/spDMTNGVEwllY d5ehV2IN1iyLsELYgmlfRU7/Fq0QEfx4xb/Q6cscmxM5ZpTfx+ZBPhVqv9sLJDX7GR jFfnoHR4szVEPWiMuYW7Bwl1xdy8S2DtouzcMqy8b/5bLaCmcamuR+DsIrJSN7d6vT i5wUG0QRApIAQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yihao Han , Hans de Goede , Helge Deller , Sasha Levin , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.18 34/53] video: fbdev: simplefb: Check before clk_put() not needed Date: Mon, 27 Jun 2022 22:18:20 -0400 Message-Id: <20220628021839.594423-34-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628021839.594423-1-sashal@kernel.org> References: <20220628021839.594423-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yihao Han [ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ] clk_put() already checks the clk ptr using !clk and IS_ERR() so there is no need to check it again before calling it. Signed-off-by: Yihao Han Reviewed-by: Hans de Goede Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/simplefb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index 2c198561c338..f96ce8801be4 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par *par, if (IS_ERR(clock)) { if (PTR_ERR(clock) == -EPROBE_DEFER) { while (--i >= 0) { - if (par->clks[i]) - clk_put(par->clks[i]); + clk_put(par->clks[i]); } kfree(par->clks); return -EPROBE_DEFER; -- 2.35.1