From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Yihao Han <hanyihao@vivo.com>,
Hans de Goede <hdegoede@redhat.com>, Helge Deller <deller@gmx.de>,
Sasha Levin <sashal@kernel.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 5.10 19/34] video: fbdev: simplefb: Check before clk_put() not needed
Date: Mon, 27 Jun 2022 22:22:26 -0400 [thread overview]
Message-ID: <20220628022241.595835-19-sashal@kernel.org> (raw)
In-Reply-To: <20220628022241.595835-1-sashal@kernel.org>
From: Yihao Han <hanyihao@vivo.com>
[ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ]
clk_put() already checks the clk ptr using !clk and IS_ERR()
so there is no need to check it again before calling it.
Signed-off-by: Yihao Han <hanyihao@vivo.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/video/fbdev/simplefb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index 533a047d07a2..85cfda4f4cf8 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -225,8 +225,7 @@ static int simplefb_clocks_get(struct simplefb_par *par,
if (IS_ERR(clock)) {
if (PTR_ERR(clock) == -EPROBE_DEFER) {
while (--i >= 0) {
- if (par->clks[i])
- clk_put(par->clks[i]);
+ clk_put(par->clks[i]);
}
kfree(par->clks);
return -EPROBE_DEFER;
--
2.35.1
next prev parent reply other threads:[~2022-06-28 2:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 2:22 [PATCH AUTOSEL 5.10 01/34] spi: spi-cadence: Fix SPI CS gets toggling sporadically Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 02/34] spi: cadence: Detect transmit FIFO depth Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 03/34] regulator: qcom_smd: correct MP5496 ranges Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 04/34] ALSA: usb-audio: US16x08: Move overflow check before array access Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 05/34] bus: bt1-apb: Don't print error on -EPROBE_DEFER Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 06/34] bus: bt1-axi: " Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 07/34] drm/vc4: crtc: Use an union to store the page flip callback Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 08/34] drm/vc4: crtc: Move the BO handling out of common page-flip callback Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 09/34] scsi: ufs: Simplify ufshcd_clear_cmd() Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 10/34] scsi: ufs: Support clearing multiple commands at once Sasha Levin
2022-06-29 12:59 ` Pavel Machek
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 11/34] ALSA: x86: intel_hdmi_audio: enable pm_runtime and set autosuspend delay Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 12/34] ALSA: x86: intel_hdmi_audio: use pm_runtime_resume_and_get() Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 13/34] hamradio: 6pack: fix array-index-out-of-bounds in decode_std_command() Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 14/34] drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 15/34] powerpc/prom_init: Fix build failure with GCC_PLUGIN_STRUCTLEAK_BYREF_ALL and KASAN Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 16/34] video: fbdev: skeletonfb: Fix syntax errors in comments Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 17/34] video: fbdev: intelfb: Use aperture size from pci_resource_len Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 18/34] video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write Sasha Levin
2022-06-28 2:22 ` Sasha Levin [this message]
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 20/34] btrfs: do not BUG_ON() on failure to migrate space when replacing extents Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 21/34] arch: mips: generic: Add missing of_node_put() in board-ranchu.c Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 22/34] mips: mti-malta: Fix refcount leak in malta-time.c Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 23/34] mips: ralink: Fix refcount leak in of.c Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 24/34] mips: lantiq: falcon: Fix refcount leak bug in sysctrl Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 25/34] mips: lantiq: xway: " Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 26/34] mips/pic32/pic32mzda: Fix refcount leak bugs Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 27/34] mips: lantiq: Add missing of_node_put() in irq.c Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 28/34] drm/sun4i: Add DMA mask and segment size Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 29/34] drm/sun4i: Return if frontend is not present Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 30/34] hinic: Replace memcpy() with direct assignment Sasha Levin
2022-06-29 13:02 ` Pavel Machek
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 31/34] drm/amdgpu: Adjust logic around GTT size (v3) Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 32/34] nvme: add a bogus subsystem NQN quirk for Micron MTFDKBA2T0TFH Sasha Levin
2022-06-28 2:22 ` [PATCH AUTOSEL 5.10 33/34] gpio: grgpio: Fix device removing Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628022241.595835-19-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hanyihao@vivo.com \
--cc=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®