From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06ADFC433EF for ; Tue, 28 Jun 2022 02:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245436AbiF1Ctf (ORCPT ); Mon, 27 Jun 2022 22:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243453AbiF1Ctd (ORCPT ); Mon, 27 Jun 2022 22:49:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CFF5B99 for ; Mon, 27 Jun 2022 19:49:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFA64612C8 for ; Tue, 28 Jun 2022 02:49:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CF26C34115; Tue, 28 Jun 2022 02:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656384572; bh=kapU6Nxs9AkJZTcW6yBcZTam6pdoSO1t+eBAIJ0Tozw=; h=From:To:Cc:Subject:Date:From; b=mVzg6JI1G6lTdKxqdJWXfeqB9TAdzTiuKu3qXoR/RpT7/35L3H/JwuA5jGcmTsfTo lYA5THsxxqgt5atpNcR6GlDw2WJuNHWEg+SKyKM/4grXBR2y067btvC7oU2UaqD40H DYxzIDJMtCeMHeyEjpKDxWNb+5svpOEa+yqTeqAO9S+/RKHVgFBxSqLnbaMI44mEdv uKXkPQ4+eVN2rPjGibp9CNBZFR0oknz1UWqGKsf/neryz1wQioPNnhv8adaBMWTdLw P8TxZlK8aUl32NMz7Wi/cqGhxhMEcrscZfYLKrJAGLyFiGo/9fKiOPjXBnsDtOvnf4 sgPclwFRPDY3A== From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 00/11] platform/chrome: Kunit tests and refactor for cros_ec_cmd_xfer() Date: Tue, 28 Jun 2022 02:49:02 +0000 Message-Id: <20220628024913.1755292-1-tzungbi@kernel.org> X-Mailer: git-send-email 2.37.0.rc0.161.g10f37bed90-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The first 5 patches add Kunit tests and refactors for cros_ec_cmd_xfer(). The last 6 patches change the behavior a bit by altering return codes. Asynchronous mechanism in EC protocol: EC returns EC_RES_IN_PROGRESS if the host command needs more time to complete. It saves the result into `saved_result` once the command completed[1]. By design, AP should send another command EC_CMD_RESEND_RESPONSE for getting the result from the previous pending command[2]. The mechanism was only designed for commands that don't need responses[3]. However, the kernel code doesn't have such logic when dealing with EC_RES_IN_PROGRESS. The series doesn't fix it but leave it as is. I doubt there is no existing use case. [1]: https://crrev.com/9b80051e01872d8cae86fff999b5d31a0bea985b/common/host_command.c#113 [2]: https://crrev.com/9b80051e01872d8cae86fff999b5d31a0bea985b/common/host_command.c#748 [3]: https://crrev.com/9b80051e01872d8cae86fff999b5d31a0bea985b/common/host_command.c#126 Return value overridden in cros_ec_send_command() if asynchronous: By original intention, cros_ec_send_command() returns number of available bytes of input payload. When it falls into asynchronous path (i.e. EC_RES_IN_PROGRESS), both return value and `msg->result` will be overridden by the subsequent EC_CMD_GET_COMMS_STATUS. The series doesn't fix it but leave it as is. Tzung-Bi Shih (11): platform/chrome: cros_ec_proto: add "cros_ec_" prefix to send_command() platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_cmd_xfer() platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_send_command() platform/chrome: cros_ec_proto: separate cros_ec_xfer_command() platform/chrome: cros_ec_proto: separate cros_ec_wait_until_complete() platform/chrome: cros_ec_proto: change Kunit expectation when timed out platform/chrome: cros_ec_proto: return -EAGAIN when retries timed out platform/chrome: cros_ec_proto: change Kunit expectation for EC errors platform/chrome: cros_ec_proto: return standard error codes for EC errors platform/chrome: cros_ec_proto: add Kunit test for empty payload platform/chrome: cros_ec_proto: return -EPROTO if empty payload drivers/platform/chrome/cros_ec_proto.c | 106 +++-- drivers/platform/chrome/cros_ec_proto_test.c | 443 +++++++++++++++++++ drivers/platform/chrome/cros_kunit_util.c | 20 + drivers/platform/chrome/cros_kunit_util.h | 4 + 4 files changed, 527 insertions(+), 46 deletions(-) -- 2.37.0.rc0.161.g10f37bed90-goog