From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>
Cc: <clement.leger@bootlin.com>, <olteanv@gmail.com>,
<f.fainelli@gmail.com>, <davem@davemloft.net>
Subject: [PATCH -next] net: pcs-rzn1-miic: fix return value check in miic_probe()
Date: Tue, 28 Jun 2022 20:08:50 +0800 [thread overview]
Message-ID: <20220628120850.3425568-1-yangyingliang@huawei.com> (raw)
If devm_platform_ioremap_resource() fails, it never return
NULL pointer, replace NULL test with IS_ERR().
Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/pcs/pcs-rzn1-miic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index 8f5e910f443d..d896961e48cc 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev)
spin_lock_init(&miic->lock);
miic->dev = dev;
miic->base = devm_platform_ioremap_resource(pdev, 0);
- if (!miic->base)
- return -EINVAL;
+ if (IS_ERR(miic->base))
+ return PTR_ERR(miic->base);
ret = devm_pm_runtime_enable(dev);
if (ret < 0)
--
2.25.1
next reply other threads:[~2022-06-28 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 12:08 Yang Yingliang [this message]
2022-06-28 12:05 ` Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628120850.3425568-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®