From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: michael@amarulasolutions.com,
Amarula patchwork <linux-amarula@amarulasolutions.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Paolo Abeni <pabeni@redhat.com>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v5 02/12] can: slcan: use netdev helpers to print out messages
Date: Tue, 28 Jun 2022 18:31:26 +0200 [thread overview]
Message-ID: <20220628163137.413025-3-dario.binacchi@amarulasolutions.com> (raw)
In-Reply-To: <20220628163137.413025-1-dario.binacchi@amarulasolutions.com>
Replace printk() calls with corresponding netdev helpers.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
(no changes since v1)
drivers/net/can/slcan.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c
index b37d35c2a23a..6162a9c21672 100644
--- a/drivers/net/can/slcan.c
+++ b/drivers/net/can/slcan.c
@@ -365,7 +365,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev)
spin_lock(&sl->lock);
if (!netif_running(dev)) {
spin_unlock(&sl->lock);
- printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name);
+ netdev_warn(dev, "xmit: iface is down\n");
goto out;
}
if (sl->tty == NULL) {
@@ -776,8 +776,7 @@ static void __exit slcan_exit(void)
sl = netdev_priv(dev);
if (sl->tty) {
- printk(KERN_ERR "%s: tty discipline still running\n",
- dev->name);
+ netdev_err(dev, "tty discipline still running\n");
}
unregister_netdev(dev);
--
2.32.0
next prev parent reply other threads:[~2022-06-28 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 16:31 [PATCH v5 00/12] can: slcan: extend supported features Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 01/12] can: slcan: use the BIT() helper Dario Binacchi
2022-06-28 16:31 ` Dario Binacchi [this message]
2022-06-28 16:31 ` [PATCH v5 03/12] can: slcan: use the alloc_can_skb() helper Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 04/12] can: netlink: dump bitrate 0 if can_priv::bittiming.bitrate is -1U Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 05/12] can: slcan: use CAN network device driver API Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 06/12] can: slcan: allow to send commands to the adapter Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 07/12] can: slcan: set bitrate by CAN device driver API Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 08/12] can: slcan: send the open/close commands to the adapter Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 09/12] can: slcan: move driver into separate sub directory Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 10/12] can: slcan: add ethtool support to reset adapter errors Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 11/12] can: slcan: extend the protocol with error info Dario Binacchi
2022-06-28 16:31 ` [PATCH v5 12/12] can: slcan: extend the protocol with CAN state info Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628163137.413025-3-dario.binacchi@amarulasolutions.com \
--to=dario.binacchi@amarulasolutions.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®