From: kernel test robot <lkp@intel.com>
To: Jiri Pirko <jiri@nvidia.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [jpirko-mlxsw:jiri_devel_devlink_locking 21/21] drivers/net/ethernet/mellanox/mlxsw/spectrum.c:2002:25: warning: unused variable 'devlink'
Date: Wed, 29 Jun 2022 01:54:08 +0800 [thread overview]
Message-ID: <202206290113.qppTEFqZ-lkp@intel.com> (raw)
tree: https://github.com/jpirko/linux_mlxsw jiri_devel_devlink_locking
head: 9162f3d685ec59a9811d91e44c3f79c51714d077
commit: 9162f3d685ec59a9811d91e44c3f79c51714d077 [21/21] x
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220629/202206290113.qppTEFqZ-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/jpirko/linux_mlxsw/commit/9162f3d685ec59a9811d91e44c3f79c51714d077
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_devlink_locking
git checkout 9162f3d685ec59a9811d91e44c3f79c51714d077
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlxsw/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/mellanox/mlxsw/spectrum.c: In function 'mlxsw_sp_ports_remove':
>> drivers/net/ethernet/mellanox/mlxsw/spectrum.c:2002:25: warning: unused variable 'devlink' [-Wunused-variable]
2002 | struct devlink *devlink = priv_to_devlink(mlxsw_sp->core);
| ^~~~~~~
vim +/devlink +2002 drivers/net/ethernet/mellanox/mlxsw/spectrum.c
b0ec003e9a9064 Jiri Pirko 2022-04-18 1998
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 1999 static void mlxsw_sp_ports_remove(struct mlxsw_sp *mlxsw_sp)
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 2000 {
b0ec003e9a9064 Jiri Pirko 2022-04-18 2001 unsigned int max_ports = mlxsw_core_max_ports(mlxsw_sp->core);
adc6462376b1a2 Jiri Pirko 2022-04-18 @2002 struct devlink *devlink = priv_to_devlink(mlxsw_sp->core);
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 2003 int i;
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 2004
b0ec003e9a9064 Jiri Pirko 2022-04-18 2005 for (i = 1; i < max_ports; i++)
b0ec003e9a9064 Jiri Pirko 2022-04-18 2006 mlxsw_sp_port_mapping_event_set(mlxsw_sp, i, false);
b0ec003e9a9064 Jiri Pirko 2022-04-18 2007 /* Make sure all scheduled events are processed */
b0ec003e9a9064 Jiri Pirko 2022-04-18 2008 __mlxsw_sp_port_mapping_events_cancel(mlxsw_sp);
b0ec003e9a9064 Jiri Pirko 2022-04-18 2009
b0ec003e9a9064 Jiri Pirko 2022-04-18 2010 for (i = 1; i < max_ports; i++)
f83e21027b4d88 Jiri Pirko 2016-10-28 2011 if (mlxsw_sp_port_created(mlxsw_sp, i))
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 2012 mlxsw_sp_port_remove(mlxsw_sp, i);
28b1987ef5064d Shalom Toledo 2019-09-16 2013 mlxsw_sp_cpu_port_remove(mlxsw_sp);
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 2014 kfree(mlxsw_sp->ports);
4340f42f207eac Jiri Pirko 2020-05-21 2015 mlxsw_sp->ports = NULL;
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 2016 }
56ade8fe3fe1e1 Jiri Pirko 2015-10-16 2017
:::::: The code at line 2002 was first introduced by commit
:::::: adc6462376b1a22d486ab5f6e624ba9528a380da mlxsw: Narrow the critical section of devl_lock during ports creation/removal
:::::: TO: Jiri Pirko <jiri@nvidia.com>
:::::: CC: David S. Miller <davem@davemloft.net>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-06-28 17:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206290113.qppTEFqZ-lkp@intel.com \
--to=lkp@intel.com \
--cc=jiri@nvidia.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®