mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jiri Pirko <jiri@nvidia.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org
Subject: [jpirko-mlxsw:jiri_devel_devlink_locking 21/21] drivers/net/ethernet/mellanox/mlxsw/core.c:1500:12: error: too few arguments to function call, single argument 'devlink' was not specified
Date: Wed, 29 Jun 2022 01:54:07 +0800	[thread overview]
Message-ID: <202206290125.jdxf7M7R-lkp@intel.com> (raw)

tree:   https://github.com/jpirko/linux_mlxsw jiri_devel_devlink_locking
head:   9162f3d685ec59a9811d91e44c3f79c51714d077
commit: 9162f3d685ec59a9811d91e44c3f79c51714d077 [21/21] x
config: x86_64-randconfig-a004-20220627 (https://download.01.org/0day-ci/archive/20220629/202206290125.jdxf7M7R-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/jpirko/linux_mlxsw/commit/9162f3d685ec59a9811d91e44c3f79c51714d077
        git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
        git fetch --no-tags jpirko-mlxsw jiri_devel_devlink_locking
        git checkout 9162f3d685ec59a9811d91e44c3f79c51714d077
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlxsw/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/mellanox/mlxsw/core.c:1500:12: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_lock();
           ~~~~~~~~~ ^
   include/net/devlink.h:1518:6: note: 'devl_lock' declared here
   void devl_lock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/core.c:1505:14: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_unlock();
           ~~~~~~~~~~~ ^
   include/net/devlink.h:1519:6: note: 'devl_unlock' declared here
   void devl_unlock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/core.c:1517:12: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_lock();
           ~~~~~~~~~ ^
   include/net/devlink.h:1518:6: note: 'devl_lock' declared here
   void devl_lock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/core.c:1524:14: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_unlock();
           ~~~~~~~~~~~ ^
   include/net/devlink.h:1519:6: note: 'devl_unlock' declared here
   void devl_unlock(struct devlink *devlink);
        ^
   4 errors generated.
--
>> drivers/net/ethernet/mellanox/mlxsw/i2c.c:643:12: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_lock();
           ~~~~~~~~~ ^
   include/net/devlink.h:1518:6: note: 'devl_lock' declared here
   void devl_lock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/i2c.c:647:14: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_unlock();
           ~~~~~~~~~~~ ^
   include/net/devlink.h:1519:6: note: 'devl_unlock' declared here
   void devl_unlock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/i2c.c:666:12: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_lock();
           ~~~~~~~~~ ^
   include/net/devlink.h:1518:6: note: 'devl_lock' declared here
   void devl_lock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/i2c.c:668:14: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_unlock();
           ~~~~~~~~~~~ ^
   include/net/devlink.h:1519:6: note: 'devl_unlock' declared here
   void devl_unlock(struct devlink *devlink);
        ^
   4 errors generated.
--
>> drivers/net/ethernet/mellanox/mlxsw/pci.c:1917:12: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_lock();
           ~~~~~~~~~ ^
   include/net/devlink.h:1518:6: note: 'devl_lock' declared here
   void devl_lock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/pci.c:1921:14: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_unlock();
           ~~~~~~~~~~~ ^
   include/net/devlink.h:1519:6: note: 'devl_unlock' declared here
   void devl_unlock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/pci.c:1880:46: warning: shift count >= width of type [-Wshift-count-overflow]
           err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
                                                       ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
   #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
                                                        ^ ~~~
   drivers/net/ethernet/mellanox/mlxsw/pci.c:1948:12: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_lock();
           ~~~~~~~~~ ^
   include/net/devlink.h:1518:6: note: 'devl_lock' declared here
   void devl_lock(struct devlink *devlink);
        ^
   drivers/net/ethernet/mellanox/mlxsw/pci.c:1950:14: error: too few arguments to function call, single argument 'devlink' was not specified
           devl_unlock();
           ~~~~~~~~~~~ ^
   include/net/devlink.h:1519:6: note: 'devl_unlock' declared here
   void devl_unlock(struct devlink *devlink);
        ^
   1 warning and 4 errors generated.


vim +/devlink +1500 drivers/net/ethernet/mellanox/mlxsw/core.c

  1491	
  1492	static int
  1493	mlxsw_devlink_core_bus_device_reload_down(struct devlink *devlink,
  1494						  bool netns_change, enum devlink_reload_action action,
  1495						  enum devlink_reload_limit limit,
  1496						  struct netlink_ext_ack *extack)
  1497	{
  1498		struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
  1499	
> 1500		devl_lock();
  1501		if (!(mlxsw_core->bus->features & MLXSW_BUS_F_RESET))
  1502			return -EOPNOTSUPP;
  1503	
  1504		mlxsw_core_bus_device_unregister(mlxsw_core, true);
  1505		devl_unlock();
  1506		return 0;
  1507	}
  1508	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-06-28 17:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206290125.jdxf7M7R-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jiri@nvidia.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®