From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Alex Williamson <alex.williamson@redhat.com>
Subject: [PATCH v3 7/7] vfio: do not set FMODE_LSEEK flag
Date: Wed, 29 Jun 2022 15:07:02 +0200 [thread overview]
Message-ID: <20220629130702.954310-8-Jason@zx2c4.com> (raw)
In-Reply-To: <20220629130702.954310-1-Jason@zx2c4.com>
This file does not support llseek, so don't set the flag advertising it.
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/vfio/vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
index 61e71c1154be..d194dda89542 100644
--- a/drivers/vfio/vfio.c
+++ b/drivers/vfio/vfio.c
@@ -1129,7 +1129,7 @@ static struct file *vfio_device_open(struct vfio_device *device)
* Appears to be missing by lack of need rather than
* explicitly prevented. Now there's need.
*/
- filep->f_mode |= (FMODE_LSEEK | FMODE_PREAD | FMODE_PWRITE);
+ filep->f_mode |= (FMODE_PREAD | FMODE_PWRITE);
if (device->group->type == VFIO_NO_IOMMU)
dev_warn(device->dev, "vfio-noiommu device opened by user "
--
2.35.1
prev parent reply other threads:[~2022-06-29 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 13:06 [PATCH v3 0/7] cleanup llseek and splice Jason A. Donenfeld
2022-06-29 13:06 ` [PATCH v3 1/7] fs: do not set no_llseek in fops Jason A. Donenfeld
2022-06-29 13:06 ` [PATCH v3 2/7] fs: clear or set FMODE_LSEEK based on llseek function Jason A. Donenfeld
2022-06-29 13:06 ` [PATCH v3 3/7] fs: check FMODE_LSEEK to control internal pipe splicing Jason A. Donenfeld
2022-06-29 13:06 ` [PATCH v3 4/7] fs: do not compare against ->llseek Jason A. Donenfeld
2022-06-29 13:07 ` [PATCH v3 5/7] fs: remove no_llseek Jason A. Donenfeld
2022-06-30 6:45 ` Nikolay Borisov
2022-06-30 13:50 ` Jason A. Donenfeld
2022-06-29 13:07 ` [PATCH v3 6/7] dma-buf: remove useless FMODE_LSEEK flag Jason A. Donenfeld
2022-06-29 13:07 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629130702.954310-8-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=alex.williamson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®