mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Roth <michael.roth@amd.com>
To: "NOMURA JUNICHI(野村 淳一)" <junichi.nomura@nec.com>
Cc: Borislav Petkov <bp@alien8.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [Regression v5.19-rc1] crash kexec fails to boot the 2nd kernel (Re: [PATCH v12 38/46] x86/sev: Add SEV-SNP feature detection/setup)
Date: Wed, 29 Jun 2022 10:35:35 -0500	[thread overview]
Message-ID: <20220629153535.ivrp2x6j74cnpsv7@amd.com> (raw)
In-Reply-To: <20220629135254.cicvyp5clm4s4n35@amd.com>

On Wed, Jun 29, 2022 at 08:52:54AM -0500, Michael Roth wrote:
> 
> So the runtime kernel relies on boot/compressed for handling EFI, and
> simply uses boot_params to pass that on to runtime kernel.
> 
> But it has its own handling for cc_blob passed via setup_data entry,
> because that entry point is meant for boot loaders / VMMs that use stuff
> like CONFIG_PVH to jump directly into decompressed kernel: those are the
> cases where we'd expect cc blob via setup_data entry. But this is a
> critical thing to support right now, and if we can't find a proper fix
> we can simply disable this patch and not check for setup_data entry in
> runtime kernel.

Sorry for the confusing typos:

I meant to say that this (setup_data-based cc blob for decompressed kernel)
*isn't* a critical thing to support right now, and disabling that boot
path is certainly an option if that ends up being necessary.

But I do think the boot/compressed issue with how it doesn't map setup_data
entries into identity map should be fixed either way, as it seems like a
latent issue that snp_init() just happens to be the first to trigger.

  reply	other threads:[~2022-06-29 15:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  0:44 NOMURA JUNICHI(野村 淳一)
2022-06-24  9:03 ` Borislav Petkov
2022-06-24 10:14   ` NOMURA JUNICHI(野村 淳一)
2022-06-29  0:41 ` Michael Roth
2022-06-29  7:38   ` NOMURA JUNICHI(野村 淳一)
2022-06-29  8:20     ` Borislav Petkov
2022-06-29 11:06       ` NOMURA JUNICHI(野村 淳一)
2022-06-29 13:52         ` Michael Roth
2022-06-29 15:35           ` Michael Roth [this message]
2022-06-29 13:54     ` Michael Roth
2022-06-30  8:25       ` NOMURA JUNICHI(野村 淳一)
2022-08-16 14:25 ` [Regression v5.19-rc1] kernel fails to boot, no console output " Jeremi Piotrowski
2022-08-16 15:06   ` Michael Roth
2022-08-17  8:40     ` Jeremi Piotrowski
2022-08-22 16:39       ` Michael Roth
2022-09-08  9:35         ` Jeremi Piotrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629153535.ivrp2x6j74cnpsv7@amd.com \
    --to=michael.roth@amd.com \
    --cc=bp@alien8.de \
    --cc=junichi.nomura@nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®