From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15B3CCA47C for ; Wed, 29 Jun 2022 20:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230362AbiF2UbB (ORCPT ); Wed, 29 Jun 2022 16:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbiF2Ua6 (ORCPT ); Wed, 29 Jun 2022 16:30:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D61B24F27; Wed, 29 Jun 2022 13:30:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D587E620FD; Wed, 29 Jun 2022 20:30:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AC1C34114; Wed, 29 Jun 2022 20:30:53 +0000 (UTC) Date: Wed, 29 Jun 2022 16:30:52 -0400 From: Steven Rostedt To: Jim Cromie Cc: jbaron@akamai.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org, daniel.vetter@ffwll.ch, seanpaul@chromium.org, robdclark@gmail.com, mathieu.desnoyers@efficios.com, quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com Subject: Re: [PATCH v2 26/27] dyndbg: 4 new trace-events: pr_debug, dev_dbg, drm_{,dev}debug Message-ID: <20220629163052.6656c0cb@gandalf.local.home> In-Reply-To: <20220516225640.3102269-27-jim.cromie@gmail.com> References: <20220516225640.3102269-1-jim.cromie@gmail.com> <20220516225640.3102269-27-jim.cromie@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for the late review. I finally got some time to look at this. On Mon, 16 May 2022 16:56:39 -0600 Jim Cromie wrote: > diff --git a/include/trace/events/drm.h b/include/trace/events/drm.h > new file mode 100644 > index 000000000000..6de80dd68620 > --- /dev/null > +++ b/include/trace/events/drm.h > @@ -0,0 +1,68 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM drm > + > +#if !defined(_TRACE_DRM_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_DRM_H > + > +#include > + > +/* drm_debug() was called, pass its args */ > +TRACE_EVENT(drm_debug, > + TP_PROTO(int drm_debug_category, struct va_format *vaf), > + > + TP_ARGS(drm_debug_category, vaf), > + > + TP_STRUCT__entry( > + __field(int, drm_debug_category) > + __dynamic_array(char, msg, 256) > + ), > + > + TP_fast_assign( > + int len; > + > + __entry->drm_debug_category = drm_debug_category; > + vsnprintf(__get_str(msg), 256, vaf->fmt, *vaf->va); > + > + len = strlen(__get_str(msg)); > + if (len > 0 && (__get_str(msg)[len - 1] == '\n')) > + len -= 1; > + __get_str(msg)[len] = 0; > + ), > + > + TP_printk("%s", __get_str(msg)) > +); > + > +/* drm_devdbg() was called, pass its args, preserving order */ > +TRACE_EVENT(drm_devdbg, > + TP_PROTO(const struct device *dev, int drm_debug_category, struct va_format *vaf), > + > + TP_ARGS(dev, drm_debug_category, vaf), > + > + TP_STRUCT__entry( > + __field(const struct device*, dev) > + __field(int, drm_debug_category) > + __dynamic_array(char, msg, 256) You do not want to hardcode the 256 here. That will cause 256 bytes to be reserved on the buffer, and you will not get that back. Might as well make it a static array, as you also add 4 bytes to for the offset and size. I think you want (haven't tested it) __dynamic_array(char, msg, get_msg_size(vaf)) Where you have: static unsigned int get_msg_size(struct va_format *vaf) { va_list aq; unsigned int ret; va_copy(aq, vaf->va); ret = vsnprintf(NULL, 0, vaf->fmt, aq); va_end(aq); return min(ret + 1, 256); } What is in the last parameter of __dynamic_array() is used to calculate the size needed to store the dynamic array. Hmm, looking at other users of __dynamic_array(), this appears to be a constant problem. I need to document this better. -- Steve > + ), > + > + TP_fast_assign( > + int len; > + > + __entry->drm_debug_category = drm_debug_category; > + __entry->dev = dev; > + vsnprintf(__get_str(msg), 256, vaf->fmt, *vaf->va); > + > + len = strlen(__get_str(msg)); > + if (len > 0 && (__get_str(msg)[len - 1] == '\n')) > + len -= 1; > + __get_str(msg)[len] = 0; > + ), > + > + TP_printk("cat:%d, %s %s", __entry->drm_debug_category, > + dev_name(__entry->dev), __get_str(msg)) > +); > + > +#endif /* _TRACE_DRM_H */ > +