From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Oleksij Rempel <linux@rempel-privat.de>,
kernel@pengutronix.de, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-tsc2046: do not explicity set INDIO_BUFFER_TRIGGERED mode
Date: Thu, 30 Jun 2022 07:07:26 +0200 [thread overview]
Message-ID: <20220630050726.GB951@pengutronix.de> (raw)
In-Reply-To: <20220629203910.4836-1-marcus.folkesson@gmail.com>
On Wed, Jun 29, 2022 at 10:39:10PM +0200, Marcus Folkesson wrote:
> The core sets INDIO_BUFFER_TRIGGERED as part of
> devm_iio_triggered_buffer_setup().
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> drivers/iio/adc/ti-tsc2046.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
> index 55b35570ad8b..0d9436a69cbf 100644
> --- a/drivers/iio/adc/ti-tsc2046.c
> +++ b/drivers/iio/adc/ti-tsc2046.c
> @@ -776,7 +776,7 @@ static int tsc2046_adc_probe(struct spi_device *spi)
> priv->spi = spi;
>
> indio_dev->name = TI_TSC2046_NAME;
> - indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
> + indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->channels = dcfg->channels;
> indio_dev->num_channels = dcfg->num_channels;
> indio_dev->info = &tsc2046_adc_info;
> --
> 2.36.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-06-30 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 20:39 Marcus Folkesson
2022-06-30 5:07 ` Oleksij Rempel [this message]
2022-07-01 16:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630050726.GB951@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=marcus.folkesson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®