From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FFCC433EF for ; Thu, 30 Jun 2022 10:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233521AbiF3KnS (ORCPT ); Thu, 30 Jun 2022 06:43:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235150AbiF3Kms (ORCPT ); Thu, 30 Jun 2022 06:42:48 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 68B0151B1A for ; Thu, 30 Jun 2022 03:41:13 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 68DA01042; Thu, 30 Jun 2022 03:41:13 -0700 (PDT) Received: from bogus (unknown [10.57.39.193]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C89463F5A1; Thu, 30 Jun 2022 03:41:09 -0700 (PDT) Date: Thu, 30 Jun 2022 11:39:58 +0100 From: Sudeep Holla To: Conor.Dooley@microchip.com Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, atishp@atishpatra.org, atishp@rivosinc.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, wangqing@vivo.com, robh+dt@kernel.org, rafael@kernel.org, ionela.voinescu@arm.com, pierre.gondois@arm.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, gshan@redhat.com, Valentina.FernandezAlanis@microchip.com Subject: Re: [PATCH v5 09/19] arch_topology: Use the last level cache information from the cacheinfo Message-ID: <20220630103958.tcear5oz3orsqwg6@bogus> References: <20220627165047.336669-1-sudeep.holla@arm.com> <20220627165047.336669-10-sudeep.holla@arm.com> <3656a067-cc3f-fd5b-e339-5925a856cce1@microchip.com> <20220629184217.krzt6l7qadymbj6h@bogus> <20220629195454.vbsjvcadmukiunt7@bogus> <03433f57-04ed-44a9-a2f6-5577df94f11e@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2022 at 11:25:41PM +0000, Conor.Dooley@microchip.com wrote: > On 29/06/2022 21:32, Conor.Dooley@microchip.com wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On 29/06/2022 20:54, Sudeep Holla wrote: > >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> > >> On Wed, Jun 29, 2022 at 07:39:43PM +0000, Conor.Dooley@microchip.com wrote: > >>> On 29/06/2022 19:42, Sudeep Holla wrote: > >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>>> > >>>> On Wed, Jun 29, 2022 at 06:18:25PM +0000, Conor.Dooley@microchip.com wrote: > >>>>> > >>>>> No, no it doesn't. Not sure what I was thinking there. > >>>>> Prob tested that on the the last commit that bisect tested > >>>>> rather than the one it pointed out the problem was with. > >>>>> > >>>>> Either way, boot is broken in -next. > >>>>> > >>>> > >>>> Can you check if the below fixes the issue? > >>> > >>> Unfortunately, no joy. > >>> Applied to a HEAD of 3b23bb2573e6 ("arch_topology: Use the > >>> last level cache information from the cacheinfo"). > >> > >> That's bad. Does the system boot with > >> Commit 2f7b757eb69d ("arch_topology: Add support to parse and detect cache > >> attributes") ? > > > > It does. > I can't think of any reason for that to happen unless detect_cache_attributes is failing from init_cpu_topology and we are ignoring that. Are all RISC-V platforms failing on -next or is it just this platform ? We may have to try with some logs in detect_cache_attributes, last_level_cache_is_valid and last_level_cache_is_shared to check where it is going wrong. It must be crashing in smp_callin->update_siblings_masks->last_level_cache_is_shared -- Regards, Sudeep