From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F953CCA47B for ; Thu, 30 Jun 2022 19:52:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236867AbiF3Twj (ORCPT ); Thu, 30 Jun 2022 15:52:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236782AbiF3Twg (ORCPT ); Thu, 30 Jun 2022 15:52:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6DB3C443E9 for ; Thu, 30 Jun 2022 12:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656618754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ExCLRUTepyP4PJv4nv3WQINVvpNQ2mK6jdr2kPhXUFc=; b=OVjKbs6bGKNFQ9FmVxmBYcI9uEiDB9+r2OCQjhakaQxhfOHCxA4TO/HBClrBh5tBW0+636 Tff15kDZzCJTZ/P7kBP7q7eBSwQAflWDWENaRf4cipJhkj6SBTgWgllwyK/I/8UyTJs99g AEk9UxfsXxmC6OavOXZc5DmZmVUZqtM= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-127-JNIdn-q_M9i3UnWY2uBWDw-1; Thu, 30 Jun 2022 15:52:33 -0400 X-MC-Unique: JNIdn-q_M9i3UnWY2uBWDw-1 Received: by mail-io1-f69.google.com with SMTP id q75-20020a6b8e4e000000b0067275f1e6c4so94610iod.14 for ; Thu, 30 Jun 2022 12:52:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ExCLRUTepyP4PJv4nv3WQINVvpNQ2mK6jdr2kPhXUFc=; b=l0yAKp6letVYuIcnknRkZtjb1kqIsDv9/Jq/72jRw5BMkoCmFTZu4tIuLcVEhE+Tpj u6a7DxnguG77QBNT1bXa69oOkGHVy6hxhGnDeykG6Ig306NiOX/qjflfxXV0+qPP6/kF PfmCt+g3KJSxDufJP/+Xurh8wH66zMmARUf4UsUeYqYSCPDY8oQG+hKnpARebv0iQCOD X9rZE+1xdc80wr34H9r39hUxbyGwS0koTN7nQyfDvSkNfdvfwFRaA9gkqupwhNyjP4jz XMKZDnpzZUyzjZLyEhSG6d4q75aKvt6SJop2eFxGEtKTbkNnWK5CRSyf6qhD6LUI6Rqi 40Ow== X-Gm-Message-State: AJIora9JfVIw88InN9Rn6gqQvroTNC34xEJ1Gyx/0gC5B5YdxOKkx8Kc QObayNYR3uM1oNwtEbV4sQeBN2nXs2cHdmggeU+9oJH13pR/6pyqIp9TiGCvHH/DW6AwpPBFaW0 2hx6vzcJ6gQYv9hEfspSUx6q6 X-Received: by 2002:a05:6638:1a8d:b0:33c:9a98:ff2d with SMTP id ce13-20020a0566381a8d00b0033c9a98ff2dmr6701517jab.31.1656618752626; Thu, 30 Jun 2022 12:52:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vV3dSvtdAEongR8ZorbRwm1TM07AxbSckZ7zfr5UPRFS8Cn4Wkuiy4T4xypOywlTXPfamwEA== X-Received: by 2002:a05:6638:1a8d:b0:33c:9a98:ff2d with SMTP id ce13-20020a0566381a8d00b0033c9a98ff2dmr6701505jab.31.1656618752455; Thu, 30 Jun 2022 12:52:32 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id x42-20020a0294ad000000b00330c5581c03sm8880286jah.1.2022.06.30.12.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 12:52:31 -0700 (PDT) Date: Thu, 30 Jun 2022 13:51:41 -0600 From: Alex Williamson To: Liam Ni Cc: cohuck@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio: check iommu_group_set_name() return value Message-ID: <20220630135141.4fd4c4d5.alex.williamson@redhat.com> In-Reply-To: <20220625114239.9301-1-zhiguangni01@gmail.com> References: <20220625114239.9301-1-zhiguangni01@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Jun 2022 19:42:39 +0800 Liam Ni wrote: > As iommu_group_set_name() can fail,we should check the return value. > > Signed-off-by: Liam Ni > --- > drivers/vfio/vfio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied to vfio next branch for v5.20. Thanks, Alex > > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > index 61e71c1154be..ca823eeac237 100644 > --- a/drivers/vfio/vfio.c > +++ b/drivers/vfio/vfio.c > @@ -504,7 +504,9 @@ static struct vfio_group *vfio_noiommu_group_alloc(struct device *dev, > if (IS_ERR(iommu_group)) > return ERR_CAST(iommu_group); > > - iommu_group_set_name(iommu_group, "vfio-noiommu"); > + ret = iommu_group_set_name(iommu_group, "vfio-noiommu"); > + if (ret) > + goto out_put_group; > ret = iommu_group_add_device(iommu_group, dev); > if (ret) > goto out_put_group;