From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Nachammai Karuppiah <nachukannan@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Frank Rowand <frowand.list@gmail.com>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [RFC PATCH 0/7] Trace events to pstore
Date: Thu, 30 Jun 2022 15:48:47 -0400 [thread overview]
Message-ID: <20220630154847.134d3d67@gandalf.local.home> (raw)
In-Reply-To: <CAEXW_YTr9VaEY78S_C5iN1EH3hySZOED8F37t1A=7PNgbQK9CA@mail.gmail.com>
On Thu, 10 Sep 2020 21:25:11 -0400
Joel Fernandes <joel@joelfernandes.org> wrote:
> Hi Rob,
> (Back from holidays, digging through the email pile). Reply below:
What ever happen to this?
Sorry, I was expecting more replies, and when there was nothing, it got
lost in my inbox.
>
> On Thu, Sep 3, 2020 at 2:09 PM Rob Herring <robh+dt@kernel.org> wrote:
> >
> > On Wed, Sep 2, 2020 at 3:47 PM Joel Fernandes <joel@joelfernandes.org> wrote:
> > >
> > > On Wed, Sep 2, 2020 at 4:01 PM Nachammai Karuppiah
> > > <nachukannan@gmail.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > This patch series adds support to store trace events in pstore.
> > > >
> > > > Storing trace entries in persistent RAM would help in understanding what
> > > > happened just before the system went down. The trace events that led to the
> > > > crash can be retrieved from the pstore after a warm reboot. This will help
> > > > debug what happened before machine’s last breath. This has to be done in a
> > > > scalable way so that tracing a live system does not impact the performance
> > > > of the system.
> > >
> > > Just to add, Nachammai was my intern in the recent outreachy program
> > > and we designed together a way for trace events to be written to
> > > pstore backed memory directory instead of regular memory. The basic
> > > idea is to allocate frace's ring buffer on pstore memory and have it
> > > right there. Then recover it on reboot. Nachammai wrote the code with
> > > some guidance :) . I talked to Steve as well in the past about the
> > > basic of idea of this. Steve is on vacation this week though.
> >
> > ramoops is already the RAM backend for pstore and ramoops already has
> > an ftrace region defined. What am I missing?
>
> ramoops is too slow for tracing. Honestly, the ftrace functionality in
> ramoops should be removed in favor of Nachammai's patches (she did it
> for events but function tracing could be trivially added). No one uses
> the current ftrace in pstore because it is darned slow. ramoops sits
> in between the writing of the ftrace record and the memory being
> written to adding more overhead in the process, while also writing
> ftrace records in a non-ftrace format. So ramoop's API and
> infrastructure fundamentally does not meet the requirements of high
> speed persistent tracing. The idea of this work is to keep the trace
> events enabled for a long period time (possibly even in production)
> and low overhead until the problem like machine crashing happens.
>
> > From a DT standpoint, we already have a reserved persistent RAM
> > binding too. There's already too much kernel specifics on how it is
> > used, we don't need more of that in DT. We're not going to add another
> > separate region (actually, you can have as many regions defined as you
> > want. They will just all be 'ramoops' compatible).
>
> I agree with the sentiment here on DT. Maybe the DT can be generalized
> to provide a ram region to which either ramoops or ramtrace can
> attach.
Right,
Perhaps just remove patch 7, but still have the ramoops work move forward?
-- Steve
next prev parent reply other threads:[~2022-06-30 19:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 20:00 Nachammai Karuppiah
2020-09-02 20:00 ` [RFC PATCH 1/7] tracing: Add support to allocate pages from persistent memory Nachammai Karuppiah
2020-09-02 20:00 ` [RFC PATCH 2/7] pstore: Support a new backend, ramtrace Nachammai Karuppiah
2020-09-02 20:00 ` [RFC PATCH 3/7] pstore: Read and iterate through trace entries in PSTORE Nachammai Karuppiah
2020-09-02 20:00 ` [RFC PATCH 4/7] pstore: Allocate and free page-sized memory in persistent RAM buffer Nachammai Karuppiah
2020-09-02 20:00 ` [RFC PATCH 5/7] tracing: Add support to iterate through pages retrieved from pstore Nachammai Karuppiah
2020-09-02 20:00 ` [RFC PATCH 6/7] tracing: Use ramtrace alloc and free methods while using persistent RAM Nachammai Karuppiah
2020-09-02 20:00 ` [RFC PATCH 7/7] dt-bindings: ramtrace: Add ramtrace DT node Nachammai Karuppiah
2020-09-02 21:47 ` [RFC PATCH 0/7] Trace events to pstore Joel Fernandes
2020-09-02 21:54 ` Joel Fernandes
2020-09-03 5:36 ` Sai Prakash Ranjan
2020-09-03 18:09 ` Rob Herring
2020-09-11 1:25 ` Joel Fernandes
2022-06-30 19:48 ` Steven Rostedt [this message]
2022-07-01 16:37 ` Joel Fernandes
2022-07-01 16:46 ` Steven Rostedt
2022-07-01 16:53 ` Joel Fernandes
2022-07-01 17:57 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630154847.134d3d67@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=computersforpeace@gmail.com \
--cc=frowand.list@gmail.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nachukannan@gmail.com \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®