From: Chen-Yu Tsai <wenst@chromium.org>
To: Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Chen-Yu Tsai <wenst@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: [PATCH 2/6] media: mediatek: vcodec: Use meaningful decoder card name including chip name
Date: Fri, 1 Jul 2022 18:52:33 +0800 [thread overview]
Message-ID: <20220701105237.932332-3-wenst@chromium.org> (raw)
In-Reply-To: <20220701105237.932332-1-wenst@chromium.org>
The card name for the video decoder previously held a static platform
name, that was fixed to match MT8173. This obviously doesn't make sense
for newer chips. Since commit a8a7a278c56a ("media: mediatek: vcodec:
Change decoder v4l2 capability value"), this field was changed to hold
the driver's name, or "mtk-vcodec-dec". This doesn't make much sense
either, since this still doesn't reflect what chip this is.
Instead, fill in the card name with "MTxxxx video decoder" with the
proper chip number.
Fixes: a8a7a278c56a ("media: mediatek: vcodec: Change decoder v4l2 capability value")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
index e7ea632a3f94..7f03dab518a4 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
@@ -248,7 +248,7 @@ static int vidioc_vdec_querycap(struct file *file, void *priv,
int platform_name = mtk_vcodec_dec_get_chip_name(priv);
strscpy(cap->driver, dev->driver->name, sizeof(cap->driver));
- strscpy(cap->card, MTK_VCODEC_DEC_NAME, sizeof(cap->card));
+ snprintf(cap->card, sizeof(cap->card), "MT%d video decoder", platform_name);
snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:mt%d-dec", platform_name);
return 0;
--
2.37.0.rc0.161.g10f37bed90-goog
next prev parent reply other threads:[~2022-07-01 10:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 10:52 [PATCH 0/6] media: mediatek-vcodec: Fix capability fields again Chen-Yu Tsai
2022-07-01 10:52 ` [PATCH 1/6] media: mediatek: vcodec: Revert driver name change in decoder capabilities Chen-Yu Tsai
2022-07-01 10:52 ` Chen-Yu Tsai [this message]
2022-07-01 10:52 ` [PATCH 3/6] media: mediatek: vcodec: Use default bus_info for decoder capability Chen-Yu Tsai
2022-07-01 10:52 ` [PATCH 4/6] media: mediatek: vcodec: Revert driver name change in encoder capabilities Chen-Yu Tsai
2022-07-08 9:19 ` Hans Verkuil
2022-07-08 9:25 ` Chen-Yu Tsai
2022-07-01 10:52 ` [PATCH 5/6] media: mediatek: vcodec: Use meaningful encoder card name including chip name Chen-Yu Tsai
2022-07-01 10:52 ` [PATCH 6/6] media: mediatek: vcodec: Use default bus_info for encoder capability Chen-Yu Tsai
[not found] ` <e601a375-cc80-40cd-9791-e44e9d37cec0@email.android.com>
2022-07-01 13:10 ` [PATCH 0/6] media: mediatek-vcodec: Fix capability fields again Chen-Yu Tsai
2022-07-04 19:01 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701105237.932332-3-wenst@chromium.org \
--to=wenst@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®