From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A1AC433EF for ; Fri, 1 Jul 2022 14:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233549AbiGAOuD (ORCPT ); Fri, 1 Jul 2022 10:50:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233504AbiGAOt4 (ORCPT ); Fri, 1 Jul 2022 10:49:56 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAA1A2E6 for ; Fri, 1 Jul 2022 07:49:55 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id q140so2596488pgq.6 for ; Fri, 01 Jul 2022 07:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pqMb0KOfCroCHzZCRJBLoaGqIjZaAOZQcoQFpuniEAU=; b=iqElCf2nLVHzYVAdYWrLj9kQextoXw5/lM+F1TrQfsSfGKjgi8lnLpOwnB8oGPInNS 2HbTjmKn9yHrrg4564kJ9H4NSE5IoLMmOcinGFBOdE3zHBUvPC3BElf5rulEJAr/uxZn sSDg7b29yWNE8Xt/PNkP44W69DRPmYl+3GYLoIF95//PIE2BKJSGnMRWMVQYbEnzGC/u u1qdEeaWdnUT5d3H+PnT+SHZ3SOG9iJLIwShR2K5Xp9yfJR3m0vxjVvacRYVV81TN4We aE+tdwu2GLaud/0R484BiVW7Viil9KBY896PDMiV3wDLU/BfmkSt5m/otBS09eIWBZD6 DZMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pqMb0KOfCroCHzZCRJBLoaGqIjZaAOZQcoQFpuniEAU=; b=6uDykwcaQ+7skyCvV5c4n7X//u64ZgSxqb6BYKiW1EQiIpmI3i4k7P8jwlITcPC41y 0TVki8+Fh1Lhy6yXaDIbt+T3vHL2elhDU/OGwZvt6S5zf6AotQ6uhQOEAx3XO90veEUf cuUj5rcazoAz+6LRpiUL2gXDxj4PmrgQ7clSUPjBOqhsBRcvqrZY/vLZ2Kel7OAV1tYn kE3mn46LBAZVfx06xyguJbB3ZvxFLWe2h5q7MkIB3Rb2J3KeCzfFE+lmHbYlBG8S7Hcq 3OW/gPp5P0BJkOSSBoazfNV4tgqJgCIwkdBxu61fJ0KXKVEENDS8QzQ14HeFu+VtYBqy ruXw== X-Gm-Message-State: AJIora8sODsZqK5Kh4wnT3V3n7d3VAwRzOyps4JIggpeW5Md4awwz/NC ZZQhKZM8yXijUZmkManvvmc= X-Google-Smtp-Source: AGRyM1ujzX4+2snf9JEZCHKobVnV3AXYNXLy92oxBVRgTjHFoVbs3ApNGjl8YMTkNld0kiTaPllBbA== X-Received: by 2002:a05:6a00:3486:b0:527:ca02:8e24 with SMTP id cp6-20020a056a00348600b00527ca028e24mr19200977pfb.34.1656686995529; Fri, 01 Jul 2022 07:49:55 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 70-20020a621849000000b0051bb79437f7sm15747872pfy.37.2022.07.01.07.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Jul 2022 07:49:54 -0700 (PDT) Sender: Guenter Roeck From: Guenter Roeck To: Huacai Chen Cc: WANG Xuerui , Guo Ren , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH 3/3] LoongArch: Always select EFI Date: Fri, 1 Jul 2022 07:49:46 -0700 Message-Id: <20220701144946.2528972-4-linux@roeck-us.net> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701144946.2528972-1-linux@roeck-us.net> References: <20220701144946.2528972-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building loongarch:allnoconfig or loongarch:tinyconfig fails with the following error. loongarch64-linux-gnu-ld: arch/loongarch/kernel/env.o: in function `init_environ': env.c:(.init.text+0xe4): undefined reference to `efi' loongarch64-linux-gnu-ld: env.c:(.init.text+0xe8): undefined reference to `efi' loongarch64-linux-gnu-ld: env.c:(.init.text+0xe8): undefined reference to `efi' loongarch64-linux-gnu-ld: env.c:(.init.text+0x108): undefined reference to `efi_get_fdt_params' loongarch64-linux-gnu-ld: env.c:(.init.text+0x11c): undefined reference to `efi_memmap_init_early' loongarch64-linux-gnu-ld: arch/loongarch/kernel/setup.o: in function `platform_init': setup.c:(.init.text+0x228): undefined reference to `efi_init' loongarch64-linux-gnu-ld: setup.c:(.init.text+0x250): undefined reference to `efi_runtime_init' loongarch64-linux-gnu-ld: arch/loongarch/kernel/mem.o: in function `memblock_init': mem.c:(.init.text+0x24): undefined reference to `efi' loongarch64-linux-gnu-ld: mem.c:(.init.text+0x28): undefined reference to `efi' loongarch64-linux-gnu-ld: mem.c:(.init.text+0x28): undefined reference to `efi' Since it is mandatory, auto-select EFI support to fix the error. Drop the EFI Kconfig help message since it is not needed. Fixes: fa96b57c1490 ("LoongArch: Add build infrastructure") Signed-off-by: Guenter Roeck --- arch/loongarch/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig index 1920d52653b4..4ed8d0916be7 100644 --- a/arch/loongarch/Kconfig +++ b/arch/loongarch/Kconfig @@ -50,6 +50,7 @@ config LOONGARCH select ARCH_WANTS_NO_INSTR select BUILDTIME_TABLE_SORT select COMMON_CLK + select EFI select GENERIC_CLOCKEVENTS select GENERIC_CMOS_UPDATE select GENERIC_CPU_AUTOPROBE @@ -296,13 +297,10 @@ config DMI DMI to identify machine quirks. config EFI - bool "EFI runtime service support" + bool select UCS2_STRING select EFI_PARAMS_FROM_FDT select EFI_RUNTIME_WRAPPERS - help - This enables the kernel to use EFI runtime services that are - available (such as the EFI variable services). config SMP bool "Multi-Processing support" -- 2.35.1