From: Daire McNamara <daire.mcnamara@microchip.com>
To: <conor@kernel.org>, <conor.dooley@microchip.com>
Cc: <aou@eecs.berkeley.edu>, <atishp@atishpatra.org>,
<daire.mcnamara@microchip.com>, <devicetree@vger.kernel.org>,
<ivan.griffin@microchip.com>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<palmer@dabbelt.com>, <palmer@rivosinc.com>,
<paul.walmsley@sifive.com>, <robh+dt@kernel.org>,
<sudeep.holla@arm.com>
Subject: Re: [PATCH] riscv: dts: microchip: hook up the mpfs's l2cache
Date: Tue, 5 Jul 2022 12:42:30 +0100 [thread overview]
Message-ID: <20220705114229.2734205-1-daire.mcnamara@microchip.com> (raw)
In-Reply-To: <20220629200732.4039258-1-conor@kernel.org>
Reviewed-by: Daire McNamara <daire.mcnamara@microchip.com>
> From: Conor Dooley <conor.dooley@microchip.com>
> Date: Monday, 4 July 2022 at 10:04
> To: FPGA ESS Linux patches <FPGA-ESS-Linux-Patches@microchip.com>
> Cc: Conor Dooley - M52691 <Conor.Dooley@microchip.com>
> Subject: [PATCH] riscv: dts: microchip: hook up the mpfs' l2cache
>
> The initial PolarFire SoC devicetree must have been forked off from
> the fu540 one prior to the addition of l2cache controller support being
> added there. When the controller node was added to mpfs.dtsi, it was
> not hooked up to the CPUs & thus sysfs reports an incorrect cache
> configuration. Hook it up.
>
> Fixes: 0fa6107eca41 ("RISC-V: Initial DTS for Microchip ICICLE board")
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> arch/riscv/boot/dts/microchip/mpfs.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/microchip/mpfs.dtsi b/arch/riscv/boot/dts/microchip/mpfs.dtsi
> index ed8739350587..2df555a57003 100644
> --- a/arch/riscv/boot/dts/microchip/mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/mpfs.dtsi
> @@ -50,6 +50,7 @@ cpu1: cpu@1 {
> riscv,isa = "rv64imafdc";
> clocks = <&clkcfg CLK_CPU>;
> tlb-split;
> + next-level-cache = <&cctrllr>;
> status = "okay";
>
> cpu1_intc: interrupt-controller {
> @@ -77,6 +78,7 @@ cpu2: cpu@2 {
> riscv,isa = "rv64imafdc";
> clocks = <&clkcfg CLK_CPU>;
> tlb-split;
> + next-level-cache = <&cctrllr>;
> status = "okay";
>
> cpu2_intc: interrupt-controller {
> @@ -104,6 +106,7 @@ cpu3: cpu@3 {
> riscv,isa = "rv64imafdc";
> clocks = <&clkcfg CLK_CPU>;
> tlb-split;
> + next-level-cache = <&cctrllr>;
> status = "okay";
>
> cpu3_intc: interrupt-controller {
> @@ -131,6 +134,7 @@ cpu4: cpu@4 {
> riscv,isa = "rv64imafdc";
> clocks = <&clkcfg CLK_CPU>;
> tlb-split;
> + next-level-cache = <&cctrllr>;
> status = "okay";
> cpu4_intc: interrupt-controller {
> #interrupt-cells = <1>;
> --
> 2.36.1
next prev parent reply other threads:[~2022-07-05 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 20:07 [PATCH] riscv: dts: microchip: hook up the mpfs' l2cache Conor Dooley
2022-06-30 15:41 ` Sudeep Holla
2022-07-05 11:42 ` Daire McNamara [this message]
2022-07-05 16:36 ` Conor Dooley
2022-07-15 17:32 ` Palmer Dabbelt
2022-07-15 17:38 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705114229.2734205-1-daire.mcnamara@microchip.com \
--to=daire.mcnamara@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivan.griffin@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®