From: Aaron Tomlin <atomlin@atomlin.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Aaron Tomlin <atomlin@redhat.com>,
rostedt@goodmis.org, cl@linux.com, pmladek@suse.com,
mbenes@suse.cz, christophe.leroy@csgroup.eu,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org, ghalat@redhat.com,
oleksandr@natalenko.name, neelx@redhat.com,
daniel.thompson@linaro.org, hch@infradead.org,
tglx@linutronix.de, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2] module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT
Date: Thu, 7 Jul 2022 19:56:19 +0100 [thread overview]
Message-ID: <20220707185619.sryhytlfkolmklnn@ava.usersys.com> (raw)
In-Reply-To: <YscV7ujYs6Q60N+E@bombadil.infradead.org>
On Thu 2022-07-07 10:20 -0700, Luis Chamberlain wrote:
> This is incredibly important information which should be added to the
> commit log, specialy as PREEMPT_RT=y becomes a first class citizen.
Understood.
>
> > So, I would say this was a regression since earlier preemption was
> > not disabled and we would dereference RCU-protected pointers explicitly
> > i.e. without using the more appropriate rcu_dereference() family
> > of primitives. That being said, these pointers cannot change in this
> > context as explained previously.
> >
> > Would the above be suitable - just to confirm before I send another
> > iteration?
>
> Yes, I would send this to Linus for the rc series. Please adjust the
> commit log with all this information.
Will do.
> BTW I think there is just one more fix pending from you right?
Yes - I will send/or prepare it as a partial revert:
's/strscpy/strlcpy/' with a brief explanation.
Kind regards,
--
Aaron Tomlin
next prev parent reply other threads:[~2022-07-07 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 16:17 Aaron Tomlin
2022-07-06 17:58 ` Luis Chamberlain
2022-07-07 16:57 ` Aaron Tomlin
2022-07-07 17:20 ` Luis Chamberlain
2022-07-07 18:56 ` Aaron Tomlin [this message]
2022-07-11 15:57 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707185619.sryhytlfkolmklnn@ava.usersys.com \
--to=atomlin@atomlin.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=daniel.thompson@linaro.org \
--cc=ghalat@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=neelx@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®