mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chengming Zhou <zhouchengming@bytedance.com>
To: mingo@redhat.com, peterz@infradead.org,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, vschneid@redhat.com
Cc: linux-kernel@vger.kernel.org,
	Chengming Zhou <zhouchengming@bytedance.com>
Subject: [PATCH 6/8] sched/fair: stop load tracking when task switched_from_fair()
Date: Sat,  9 Jul 2022 23:13:51 +0800	[thread overview]
Message-ID: <20220709151353.32883-7-zhouchengming@bytedance.com> (raw)
In-Reply-To: <20220709151353.32883-1-zhouchengming@bytedance.com>

The same reason as the previous commit, if we don't reset the
sched_avg last_update_time to 0, after a while in switched_to_fair():

switched_to_fair
  attach_task_cfs_rq
    attach_entity_cfs_rq
      update_load_avg
        __update_load_avg_se(now, cfs_rq, se)

The delta (now - sa->last_update_time) will wrongly contribute/decay
sched_avg depends on the task running/runnable status at that time.

This patch reset it's sched_avg last_update_time to 0, stop load
tracking for !fair task, later in switched_to_fair() ->
update_load_avg(), we can use its saved sched_avg.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 kernel/sched/fair.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 153a2c6c1069..ca714eedeec5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -11563,6 +11563,11 @@ static void attach_task_cfs_rq(struct task_struct *p)
 static void switched_from_fair(struct rq *rq, struct task_struct *p)
 {
 	detach_task_cfs_rq(p);
+
+#ifdef CONFIG_SMP
+	/* Stop load tracking for !fair task */
+	p->se.avg.last_update_time = 0;
+#endif
 }
 
 static void switched_to_fair(struct rq *rq, struct task_struct *p)
-- 
2.36.1


  parent reply	other threads:[~2022-07-09 15:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-09 15:13 [PATCH 0/8] sched: task load tracking optimization and cleanup Chengming Zhou
2022-07-09 15:13 ` [PATCH 1/8] sched/fair: combine detach into dequeue when migrating task Chengming Zhou
2022-07-11 13:07   ` Chengming Zhou
2022-07-09 15:13 ` [PATCH 2/8] sched/fair: update comments in enqueue/dequeue_entity() Chengming Zhou
2022-07-09 15:13 ` [PATCH 3/8] sched/fair: remove redundant cpu_cgrp_subsys->fork() Chengming Zhou
2022-07-11  7:35   ` Peter Zijlstra
2022-07-11 13:02     ` [External] " Chengming Zhou
2022-07-11 13:53       ` Peter Zijlstra
2022-07-11 16:25         ` Chengming Zhou
2022-07-09 15:13 ` [PATCH 4/8] sched/fair: reset sched_avg last_update_time before set_task_rq() Chengming Zhou
2022-07-09 15:13 ` [PATCH 5/8] sched/fair: fix load tracking for new forked !fair task Chengming Zhou
2022-07-09 15:13 ` Chengming Zhou [this message]
2022-07-09 15:13 ` [PATCH 7/8] sched/fair: delete superfluous set_task_rq_fair() Chengming Zhou
2022-07-09 15:13 ` [PATCH 8/8] sched/fair: delete superfluous SKIP_AGE_LOAD Chengming Zhou
2022-07-11 16:54   ` Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220709151353.32883-7-zhouchengming@bytedance.com \
    --to=zhouchengming@bytedance.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®