From: Zhu Ning <zhuning0077@gmail.com>
To: vijendar.mukunda@amd.com
Cc: Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
alsa-devel@alsa-project.org, amadeuszx.slawinski@linux.intel.com,
broonie@kernel.org, christophe.jaillet@wanadoo.fr,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org, lkp@intel.com,
tiwai@suse.com, zhuning@everest-semi.com
Subject: Re: [PATCH 3/3] ASoC: amd: fix for variable set but not used warning
Date: Mon, 11 Jul 2022 10:59:33 +0800 [thread overview]
Message-ID: <20220711025933.3445-1-zhuning0077@gmail.com> (raw)
In-Reply-To: <d2828d36-275e-60d7-782e-2bff265bae0b@amd.com>
This code is ok. The machine driver should still function well without gpio.
if (IS_ERR(gpio_pa)) {
gpiod_put(gpio_pa);
put_device(codec_dev);
return dev_err_probe(card->dev, PTR_ERR(gpio_pa),
"could not get pa-enable GPIO\n");
}
You donnot need to handle null gpio_pa gpio.
if (!(IS_ERR_OR_NULL(gpio_pa)))
gpiod_set_value_cansleep(gpio_pa, true);
next prev parent reply other threads:[~2022-07-11 2:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 13:26 [PATCH 1/3] ASoC: amd: remove unused header file inclusion Vijendar Mukunda
2022-07-07 13:26 ` [PATCH 2/3] ASoC: amd: drop machine driver remove function Vijendar Mukunda
2022-07-07 13:26 ` [PATCH 3/3] ASoC: amd: fix for variable set but not used warning Vijendar Mukunda
2022-07-09 7:33 ` Christophe JAILLET
2022-07-09 11:12 ` Mukunda,Vijendar
2022-07-11 2:59 ` Zhu Ning [this message]
2022-07-08 20:47 ` [PATCH 1/3] ASoC: amd: remove unused header file inclusion Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711025933.3445-1-zhuning0077@gmail.com \
--to=zhuning0077@gmail.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tiwai@suse.com \
--cc=vijendar.mukunda@amd.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®