From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D32EC433EF for ; Sun, 10 Jul 2022 22:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbiGJW2R (ORCPT ); Sun, 10 Jul 2022 18:28:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiGJW2P (ORCPT ); Sun, 10 Jul 2022 18:28:15 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90FBA13EBC; Sun, 10 Jul 2022 15:28:13 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Lh1qq71Bzz4xhn; Mon, 11 Jul 2022 08:28:07 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1657492088; bh=t2x2etyRIE9UyBEZxb6gCj5pB9F+yYo2kF1BwbNXc80=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M11jrNWPw7pyiQvQhFU7d4enjLEA8FLuj6KPKofCJFSmYWXdVhJSNCIqm/jbDWZfS 6QlmKRmkXdsNG9pYExPQEI10FePRb4GdkDLuBEmWbM2E4lkR0CPwZ7x9cL9ct8MKHQ yYoHry4Gd5Yqpx0hMeIL9NusFmpvNE8jEkHeUFlptmmHQmb9+hDb73mt/SnS5l0Y12 8qmYZpRc3rvVgbdVPOXGpYsZKCiujIUZ/9kSFn+7FoGWEnfpBgYY5b/XxQ3dwVogRz NNa3G0yMDg4kkAsE65nDnfZ6JoxppeFQ74aKOlHe4qiBf3WpoUIa8sWZMRwaoc5OXa 7HxSN9ksaSwWA== Date: Mon, 11 Jul 2022 08:28:07 +1000 From: Stephen Rothwell To: "Darrick J. Wong" Cc: Andrew Morton , David Chinner , linux-xfs@vger.kernel.org, Shiyang Ruan , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the mm tree Message-ID: <20220711082807.745ee22d@canb.auug.org.au> In-Reply-To: References: <20220708194437.7eafe774@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/7D3RKxNX24FwTFPfEbTajvY"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/7D3RKxNX24FwTFPfEbTajvY Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Darrick, On Fri, 8 Jul 2022 08:17:51 -0700 "Darrick J. Wong" wro= te: > > This isn't quite correct -- references to xfs_perag objects must be > released once they are acquired. The following patch against today's > tree fixes this problem: >=20 > diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c > index f3c62c19475e..69d9c83ea4b2 100644 > --- a/fs/xfs/xfs_notify_failure.c > +++ b/fs/xfs/xfs_notify_failure.c > @@ -127,10 +127,12 @@ xfs_dax_notify_ddev_failure( > =20 > pag =3D xfs_perag_get(mp, agno); > error =3D xfs_alloc_read_agf(pag, tp, 0, &agf_bp); > - if (error) > + if (error) { > + xfs_perag_put(pag); > break; > + } > =20 > - cur =3D xfs_rmapbt_init_cursor(mp, tp, agf_bp, agf_bp->b_pag); > + cur =3D xfs_rmapbt_init_cursor(mp, tp, agf_bp, pag); > =20 > /* > * Set the rmap range from ri_low to ri_high, which represents > @@ -151,6 +153,7 @@ xfs_dax_notify_ddev_failure( > xfs_dax_failure_fn, ¬ify); > xfs_btree_del_cursor(cur, error); > xfs_trans_brelse(tp, agf_bp); > + xfs_perag_put(pag); > if (error) > break; > =20 Thanks, I will add that to the resolution from today. --=20 Cheers, Stephen Rothwell --Sig_/7D3RKxNX24FwTFPfEbTajvY Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmLLUncACgkQAVBC80lX 0GwlqAf/WeUw62MEgfmaLpCUh5mt5gqu50WTo4hdDHEOXVoMxDFqz1EY/LbzAcUu twtMKf60dMR1IS3zbgekFKLVuAjGu4Nwrjvj+nha6EOjxyf/4o4a3IZyL69NN8HY /hJsw3hQ7Fj1N7PfdF/gbj90+IU5Tpejdx4gDTqdMfoLuzjsatQVc4zM3IKneB3h gqDYttyBbQA33VwvCxPmkh3kSfk5ZnGN+bWTcAUyqk0WMDma3XTENZgMpIGP5308 3OMHayMLhsJQL/TXfcLLKNm1qbQuJV2JvB4ayp1X1D7zQ9bO5yeorZAGVy/r3qyJ DYQVDxlSJxWcnvkpmsCopzdIy0aoYQ== =RLOP -----END PGP SIGNATURE----- --Sig_/7D3RKxNX24FwTFPfEbTajvY--