From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9C4C43334 for ; Mon, 11 Jul 2022 20:55:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231799AbiGKUzm (ORCPT ); Mon, 11 Jul 2022 16:55:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231757AbiGKUzi (ORCPT ); Mon, 11 Jul 2022 16:55:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C1A15C35F for ; Mon, 11 Jul 2022 13:55:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0630AB8112C for ; Mon, 11 Jul 2022 20:55:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08CA3C341C0; Mon, 11 Jul 2022 20:55:33 +0000 (UTC) Date: Mon, 11 Jul 2022 16:55:32 -0400 From: Steven Rostedt To: Li kunyu Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Tejun Heo , Jens Axboe Subject: Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon Message-ID: <20220711165532.10476a0b@gandalf.local.home> In-Reply-To: <20220629030013.10362-1-kunyu@nfschina.com> References: <20220629030013.10362-1-kunyu@nfschina.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jens, Want to take this one? Or I can if you don't. -- Steve On Wed, 29 Jun 2022 11:00:13 +0800 Li kunyu wrote: > I think this semicolon could be deleted. > > Signed-off-by: Li kunyu > --- > include/trace/events/iocost.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h > index e282ce02fa2d..6d1626e7a4ce 100644 > --- a/include/trace/events/iocost.h > +++ b/include/trace/events/iocost.h > @@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj, > > TP_fast_assign( > __assign_str(devname, ioc_name(ioc)); > - __entry->old_vrate = atomic64_read(&ioc->vtime_rate);; > + __entry->old_vrate = atomic64_read(&ioc->vtime_rate); > __entry->new_vrate = new_vrate; > __entry->busy_level = ioc->busy_level; > __entry->read_missed_ppm = missed_ppm[READ];