From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 433E3C433EF for ; Tue, 12 Jul 2022 01:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232179AbiGLB4K (ORCPT ); Mon, 11 Jul 2022 21:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232133AbiGLB4F (ORCPT ); Mon, 11 Jul 2022 21:56:05 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2321C3D5BA for ; Mon, 11 Jul 2022 18:56:04 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id o8-20020a17090ab88800b001ef81869167so6752456pjr.2 for ; Mon, 11 Jul 2022 18:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=x8hGnQGu+TvLoNX/lMBZXMk6ueNBJ63tvcwEjiE74A0=; b=NpwIJ4rTQn6uFIpOi3K/qjN6ir94/cFp6kvxo+/rzokC7IixIq4YbRe6iqqI6i0iPV 8VoH51o0XES5Nhdo7ZwOCxrrTOJ7IPQV6uVFCOHgepoZVDkzg/94+5hg4GjDJnZce5Lm dzs0Jbz+Gu8ioS0gPIvW5FOxrwNgJr30UtOAU/P7rvIkzz5fBo3LjE5rAJ6cj2nUTR9Z U8SVr+wn0hg54CDS1Cc8FSeYrRu7oySeMlY21VQH9rNDuWQUgr4rs8ea0zLtf3gkO2a/ IeXWU3u4Xzzqu4YPiVeHBwyVnZ56Bym2IDzJzd/wIvdllfG0PqllHDgLgUTtCDd79bKI fX7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=x8hGnQGu+TvLoNX/lMBZXMk6ueNBJ63tvcwEjiE74A0=; b=m7C4IymDlSzzl1bsvp4sT3w+bzJ5rfDSRFf4zdejJapOxX4Q5rMke1iROn2JjiHDIh DkboeTEKOmBKUOXeZXqgnJZ++vC+lYdfCScOfloNaZ1JUcUqxxhVVFHjRAMzHdEb5M9o 8GHNbWmAYeF6qFphWu27aGuiFoe/wZ6ua0t2OClgIMm8r8m9KsULzwbNlPjBPAOhlzH7 4fnZFsDpA3n0llPxD1JUHAHgiK/uvdmmgRerfhhQzw5gduPdWb3L/B1JiEGJslFkQ3Es JabuSW7JHQx823CY7/C8Lb2Q1MYHjP5Ggaj0PIG0qxC/NkKwVqHNCTu0XCLbjBut+4cl AEOg== X-Gm-Message-State: AJIora+HEabHGapBorkxOGTSta+V7ztAZvpN83RHwH5Dahl4teMFFa6O BNIncbLfWNW6xYttVLqBdqX+bW6QYKE= X-Google-Smtp-Source: AGRyM1tVehKyCGq7CmihonY0Z7mBNOc9uJhBx26VsPzpgF14z2+zZ3LBeFfhk3GSUT5o3xfyxevM9thX+NM= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:778c:b0:16a:6cd5:469f with SMTP id o12-20020a170902778c00b0016a6cd5469fmr21837101pll.102.1657590963692; Mon, 11 Jul 2022 18:56:03 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 12 Jul 2022 01:55:54 +0000 In-Reply-To: <20220712015558.1247978-1-seanjc@google.com> Message-Id: <20220712015558.1247978-2-seanjc@google.com> Mime-Version: 1.0 References: <20220712015558.1247978-1-seanjc@google.com> X-Mailer: git-send-email 2.37.0.144.g8ac04bfd2-goog Subject: [PATCH 1/5] KVM: x86/mmu: Return a u64 (the old SPTE) from mmu_spte_clear_track_bits() From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return a u64, not an int, from mmu_spte_clear_track_bits(). The return value is the old SPTE value, which is very much a 64-bit value. The sole caller that consumes the return value, drop_spte(), already uses a u64. The only reason that truncating the SPTE value is not problematic is because drop_spte() only queries the shadow-present bit, which is in the lower 32 bits. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index f7fa4c31b7c5..2605d6ebc193 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -529,7 +529,7 @@ static bool mmu_spte_update(u64 *sptep, u64 new_spte) * state bits, it is used to clear the last level sptep. * Returns the old PTE. */ -static int mmu_spte_clear_track_bits(struct kvm *kvm, u64 *sptep) +static u64 mmu_spte_clear_track_bits(struct kvm *kvm, u64 *sptep) { kvm_pfn_t pfn; u64 old_spte = *sptep; -- 2.37.0.144.g8ac04bfd2-goog