From: Steven Rostedt <rostedt@goodmis.org>
To: Schspa Shi <schspa@gmail.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org,
zhaohui.shi@horizon.ai
Subject: Re: [PATCH v5 1/2] sched/rt: fix bad task migration for rt tasks
Date: Tue, 12 Jul 2022 09:53:25 -0400 [thread overview]
Message-ID: <20220712095325.408d1730@gandalf.local.home> (raw)
In-Reply-To: <20220712013125.623338-1-schspa@gmail.com>
On Tue, 12 Jul 2022 09:31:24 +0800
Schspa Shi <schspa@gmail.com> wrote:
> @@ -1998,11 +1998,15 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq)
> * the mean time, task could have
> * migrated already or had its affinity changed.
> * Also make sure that it wasn't scheduled on its rq.
> + * It is possible the task was scheduled, set
> + * "migrate_disabled" and then got preempted, And we
> + * check task migration disable flag here too.
Nit. "got preempted, so we must check the task migration disable flag here
too".
But other than that.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
> */
next prev parent reply other threads:[~2022-07-12 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 1:31 Schspa Shi
2022-07-12 1:31 ` [PATCH v5 2/2] sched/rt: Trying to push current task when target disable migrating Schspa Shi
2022-07-12 14:29 ` Steven Rostedt
2022-07-12 14:34 ` Schspa Shi
2022-07-12 13:53 ` Steven Rostedt [this message]
2022-07-12 14:37 ` [PATCH v5 1/2] sched/rt: fix bad task migration for rt tasks Schspa Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712095325.408d1730@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=schspa@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhaohui.shi@horizon.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®