mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@sifive.com>
To: linux-pwm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	u.kleine-koenig@pengutronix.de,
	Thierry Reding <thierry.reding@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Greentime Hu <greentime.hu@sifive.com>,
	Jude Onyenegecha <jude.onyenegecha@sifive.com>,
	Sudip Mukherjee <sudip.mukherjee@sifive.com>,
	William Salmon <william.salmon@sifive.com>,
	Adnan Chowdhury <adnan.chowdhury@sifive.com>,
	Ben Dooks <ben.dooks@sifive.com>
Subject: [PATCH 2/7] pwm: move dwc memory alloc to own function
Date: Tue, 12 Jul 2022 11:01:08 +0100	[thread overview]
Message-ID: <20220712100113.569042-3-ben.dooks@sifive.com> (raw)
In-Reply-To: <20220712100113.569042-1-ben.dooks@sifive.com>

In preparation for adding other bus support, move the allocation
of the pwm struct out of the main driver code.

Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
---
 drivers/pwm/pwm-dwc.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
index c706ef9a7ba1..61f11e0a9319 100644
--- a/drivers/pwm/pwm-dwc.c
+++ b/drivers/pwm/pwm-dwc.c
@@ -196,13 +196,29 @@ static const struct pwm_ops dwc_pwm_ops = {
 	.owner = THIS_MODULE,
 };
 
+static struct dwc_pwm *dwc_pwm_alloc(struct device *dev)
+{
+	struct dwc_pwm *dwc;
+
+	dwc = devm_kzalloc(dev, sizeof(*dwc), GFP_KERNEL);
+	if (!dwc)
+		return NULL;
+
+	dwc->chip.dev = dev;
+	dwc->chip.ops = &dwc_pwm_ops;
+	dwc->chip.npwm = DWC_TIMERS_TOTAL;
+
+	dev_set_drvdata(dev, dwc);
+	return dwc;
+}
+
 static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 {
 	struct device *dev = &pci->dev;
 	struct dwc_pwm *dwc;
 	int ret;
 
-	dwc = devm_kzalloc(dev, sizeof(*dwc), GFP_KERNEL);
+	dwc = dwc_pwm_alloc(dev);
 	if (!dwc)
 		return -ENOMEM;
 
@@ -226,12 +242,6 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
 		return -ENOMEM;
 	}
 
-	pci_set_drvdata(pci, dwc);
-
-	dwc->chip.dev = dev;
-	dwc->chip.ops = &dwc_pwm_ops;
-	dwc->chip.npwm = DWC_TIMERS_TOTAL;
-
 	ret = pwmchip_add(&dwc->chip);
 	if (ret)
 		return ret;
-- 
2.35.1


  parent reply	other threads:[~2022-07-12 10:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 10:01 update synopsys driver for platform/devicetree support Ben Dooks
2022-07-12 10:01 ` [PATCH 1/7] pwm: change &pci->dev to dev in probe Ben Dooks
2022-07-13  8:16   ` Uwe Kleine-König
2022-07-13 10:54     ` Ben Dooks
2022-07-18  7:19     ` Ben Dooks
2022-07-18  7:49       ` Uwe Kleine-König
2022-07-18  7:54         ` Uwe Kleine-König
2022-07-12 10:01 ` Ben Dooks [this message]
2022-07-12 10:01 ` [PATCH 3/7] pwm: dwc: add of/platform support Ben Dooks
2022-07-12 10:08   ` Krzysztof Kozlowski
2022-07-13  9:21     ` Ben Dooks
2022-07-13  9:26       ` Krzysztof Kozlowski
2022-07-12 14:26   ` Rob Herring
2022-07-13 12:06     ` Ben Dooks
2022-07-12 22:17   ` Rob Herring
2022-07-13 11:56     ` Ben Dooks
2022-07-13 13:52       ` Uwe Kleine-König
2022-07-13 14:30         ` Ben Dooks
2022-07-13 15:07           ` Uwe Kleine-König
2022-07-13 16:20             ` Ben Dooks
2022-07-18  7:18             ` Ben Dooks
2022-07-12 10:01 ` [PATCH 4/7] pwm: dwc: allow driver to be built with COMPILE_TEST Ben Dooks
2022-07-12 10:01 ` [PATCH 5/7] pwm: dwc: add timer clock Ben Dooks
2022-07-13  6:10   ` Uwe Kleine-König
2022-07-12 10:01 ` [PATCH 6/7] pwm: dwc: remove the CONFIG_OF in " Ben Dooks
2022-07-12 10:09   ` Krzysztof Kozlowski
2022-07-12 10:20     ` Ben Dooks
2022-07-13  6:11       ` Uwe Kleine-König
2022-07-18  7:18         ` Ben Dooks
2022-07-13  9:31     ` Ben Dooks
2022-07-12 10:01 ` [PATCH 7/7] pwm: dwc: add snps,pwm-number to limit pwm count Ben Dooks
2022-07-12 10:09   ` Krzysztof Kozlowski
2022-07-18 20:08   ` Rob Herring
2022-07-19  8:20     ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220712100113.569042-3-ben.dooks@sifive.com \
    --to=ben.dooks@sifive.com \
    --cc=adnan.chowdhury@sifive.com \
    --cc=devicetree@vger.kernel.org \
    --cc=greentime.hu@sifive.com \
    --cc=jude.onyenegecha@sifive.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=sudip.mukherjee@sifive.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=william.salmon@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®