From: Michael Walle <michael@walle.cc>
To: Xu Liang <lxu@maxlinear.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Walle <michael@walle.cc>
Subject: [PATCH net-next 3/4] net: phy: mxl-gpy: rename the FW type field name
Date: Tue, 12 Jul 2022 15:15:53 +0200 [thread overview]
Message-ID: <20220712131554.2737792-4-michael@walle.cc> (raw)
In-Reply-To: <20220712131554.2737792-1-michael@walle.cc>
Align the firmware field name with the reference manual where it is
called "major".
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/net/phy/mxl-gpy.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index b6303089d425..ac62b01c61ed 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -56,7 +56,7 @@
PHY_IMASK_ANC)
#define PHY_FWV_REL_MASK BIT(15)
-#define PHY_FWV_TYPE_MASK GENMASK(11, 8)
+#define PHY_FWV_MAJOR_MASK GENMASK(11, 8)
#define PHY_FWV_MINOR_MASK GENMASK(7, 0)
/* SGMII */
@@ -78,12 +78,12 @@
#define WOL_EN BIT(0)
struct gpy_priv {
- u8 fw_type;
+ u8 fw_major;
u8 fw_minor;
};
static const struct {
- int type;
+ int major;
int minor;
} ver_need_sgmii_reaneg[] = {
{7, 0x6D},
@@ -222,7 +222,7 @@ static int gpy_probe(struct phy_device *phydev)
fw_version = phy_read(phydev, PHY_FWV);
if (fw_version < 0)
return fw_version;
- priv->fw_type = FIELD_GET(PHY_FWV_TYPE_MASK, fw_version);
+ priv->fw_major = FIELD_GET(PHY_FWV_MAJOR_MASK, fw_version);
priv->fw_minor = FIELD_GET(PHY_FWV_MINOR_MASK, fw_version);
ret = gpy_hwmon_register(phydev);
@@ -242,7 +242,7 @@ static bool gpy_sgmii_need_reaneg(struct phy_device *phydev)
size_t i;
for (i = 0; i < ARRAY_SIZE(ver_need_sgmii_reaneg); i++) {
- if (priv->fw_type != ver_need_sgmii_reaneg[i].type)
+ if (priv->fw_major != ver_need_sgmii_reaneg[i].major)
continue;
if (priv->fw_minor < ver_need_sgmii_reaneg[i].minor)
return true;
--
2.30.2
next prev parent reply other threads:[~2022-07-12 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 13:15 [PATCH net-next 0/4] net: phy: mxl-gpy: version fix and improvements Michael Walle
2022-07-12 13:15 ` [PATCH net-next 1/4] net: phy: mxl-gpy: fix version reporting Michael Walle
2022-07-12 13:19 ` Andrew Lunn
2022-07-12 13:15 ` [PATCH net-next 2/4] net: phy: mxl-gpy: cache PHY firmware version Michael Walle
2022-07-12 13:24 ` Andrew Lunn
2022-07-12 13:27 ` Michael Walle
2022-07-12 13:31 ` Andrew Lunn
2022-07-12 13:15 ` Michael Walle [this message]
2022-07-12 13:26 ` [PATCH net-next 3/4] net: phy: mxl-gpy: rename the FW type field name Andrew Lunn
2022-07-12 13:15 ` [PATCH net-next 4/4] net: phy: mxl-gpy: print firmware in human readable form Michael Walle
2022-07-12 13:27 ` Andrew Lunn
2022-07-13 13:30 ` [PATCH net-next 0/4] net: phy: mxl-gpy: version fix and improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712131554.2737792-4-michael@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®