From: Steven Rostedt <rostedt@goodmis.org>
To: Zheng Yejian <zhengyejian1@huawei.com>
Cc: <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
<tom.zanussi@linux.intel.com>, <trix@redhat.com>,
<stable@vger.kernel.org>, <zhangjinhao2@huawei.com>
Subject: Re: [PATCH] tracing/histograms: Simplify create_hist_fields()
Date: Tue, 12 Jul 2022 13:52:31 -0400 [thread overview]
Message-ID: <20220712135231.68d08a6f@gandalf.local.home> (raw)
In-Reply-To: <20220630013152.164871-1-zhengyejian1@huawei.com>
On Thu, 30 Jun 2022 09:31:52 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 2784951e0fc8..832c4ccf41ab 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -4454,7 +4454,7 @@ static int create_hist_fields(struct hist_trigger_data *hist_data,
>
> ret = parse_var_defs(hist_data);
> if (ret)
> - goto out;
> + return ret;
This is a functional change.
>
> ret = create_val_fields(hist_data, file);
> if (ret)
> @@ -4465,8 +4465,7 @@ static int create_hist_fields(struct hist_trigger_data *hist_data,
> goto out;
>
> ret = create_key_fields(hist_data, file);
> - if (ret)
> - goto out;
> +
> out:
This is not a functional change ;-)
If you just had the latter, then it would have been OK to state "No
functional changes".
-- Steve
> free_var_defs(hist_data);
>
prev parent reply other threads:[~2022-07-12 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 1:31 Zheng Yejian
2022-06-30 2:24 ` Tom Rix
2022-06-30 6:33 ` Greg KH
2022-06-30 9:21 ` Zhengyejian (Zetta)
2022-07-12 17:49 ` Steven Rostedt
2022-07-13 10:32 ` Zheng Yejian
2022-07-12 17:52 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712135231.68d08a6f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tom.zanussi@linux.intel.com \
--cc=trix@redhat.com \
--cc=zhangjinhao2@huawei.com \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®