From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Lee Jones <lee.jones@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org
Subject: [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible
Date: Tue, 12 Jul 2022 18:33:40 +0200 [thread overview]
Message-ID: <20220712163345.445811-1-francesco.dolcini@toradex.com> (raw)
Hi all,
This series update the STMPE MFD driver to use of_compatible to probe for
sub-functions instead of using hardcoded names. Matching by name does not seems
in general a good idea, in this specific case it is even worst since the node
name are not compliant to the current naming convention (they are not generic
and they do include underscores), and because of that recently
we had a regression introduced [1].
This change was suggested by Ahmad Fatoum [2].
[1] commit 56086b5e ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name")
[2] https://lore.kernel.org/all/86815346-209e-304e-3565-b4160afa48e8@pengutronix.de/
Changes in v2:
- split in a separate patch the removal of rotator from probe
- remove define usage for compatible strings
Francesco Dolcini (5):
mfd: stmpe: Remove rotator block from probe
mfd: stmpe: Probe sub-function by compatible
dt-bindings: gpio: stmpe: Remove node name requirement
dt-bindings: iio: adc: stmpe: Remove node name requirement
dt-bindings: input: touchscreen: stmpe: Remove node name requirement
.../devicetree/bindings/gpio/gpio-stmpe.txt | 3 +--
.../devicetree/bindings/iio/adc/st,stmpe-adc.yaml | 3 +--
.../devicetree/bindings/input/touchscreen/stmpe.txt | 3 +--
drivers/mfd/stmpe.c | 13 +++++--------
4 files changed, 8 insertions(+), 14 deletions(-)
--
2.25.1
next reply other threads:[~2022-07-12 16:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 16:33 Francesco Dolcini [this message]
2022-07-12 16:33 ` [PATCH v2 1/5] mfd: stmpe: Remove rotator block from probe Francesco Dolcini
2022-08-08 15:17 ` Lee Jones
2022-07-12 16:33 ` [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
2022-07-18 9:20 ` Linus Walleij
2022-08-08 15:18 ` Lee Jones
2022-07-12 16:33 ` [PATCH v2 3/5] dt-bindings: gpio: stmpe: Remove node name requirement Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
2022-07-13 7:43 ` Bartosz Golaszewski
2022-07-18 10:43 ` Francesco Dolcini
2022-08-09 13:48 ` Francesco Dolcini
2022-08-31 19:57 ` Bartosz Golaszewski
2022-07-12 16:33 ` [PATCH v2 4/5] dt-bindings: iio: adc: " Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
2022-07-13 16:24 ` Jonathan Cameron
2022-08-09 13:46 ` Francesco Dolcini
2022-08-09 15:37 ` Lee Jones
2022-08-13 15:05 ` Jonathan Cameron
2022-07-12 16:33 ` [PATCH v2 5/5] dt-bindings: input: touchscreen: " Francesco Dolcini
2022-07-12 21:23 ` Krzysztof Kozlowski
2022-08-09 13:50 ` Francesco Dolcini
2022-09-05 7:22 ` Francesco Dolcini
2022-09-06 3:15 ` Dmitry Torokhov
2022-08-09 7:54 ` [PATCH v2 0/5] mfd: stmpe: Probe sub-function by compatible Francesco Dolcini
2022-08-09 13:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712163345.445811-1-francesco.dolcini@toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=alexandre.torgue@foss.st.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®