mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	linux-media@vger.kernel.org,
	quentin.schulz@theobroma-systems.com,
	Daniel Scally <djrscally@gmail.com>,
	linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding
Date: Wed, 13 Jul 2022 15:24:51 +0200	[thread overview]
Message-ID: <20220713132451.GA1725944@tom-ThinkPad-T14s-Gen-2i> (raw)
In-Reply-To: <87086513-787c-3b0d-80df-b90ebdc3a28c@linaro.org>

On Wed, Jul 13, 2022 at 08:52:34AM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2022 08:48, Tommaso Merciai wrote:
> > Hi Rob,
> > 
> > On Tue, Jul 12, 2022 at 04:29:35PM -0600, Rob Herring wrote:
> >> On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote:
> >>> Add documentation of device tree in YAML schema for the OV5693
> >>> CMOS image sensor from Omnivision
> >>>
> >>> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> ---
> >>> Changes since v1:
> >>>  - Fix allOf position as suggested by Krzysztof
> >>>  - Remove port description as suggested by Krzysztof
> >>>  - Fix EOF as suggested by Krzysztof
> >>>
> >>> Changes since v2:
> >>>  - Fix commit body as suggested by Krzysztof
> >>>
> >>> Changes since v3:
> >>>  - Add reviewed-by tags, suggested by Jacopo, Krzysztof
> >>>
> >>> Changes since v4:
> >>>  - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari
> >>>
> >>> Changes since v5:
> >>>  - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties
> >>> as suggested by Jacopo
> >>>
> >>>  .../bindings/media/i2c/ovti,ov5693.yaml       | 103 ++++++++++++++++++
> >>>  MAINTAINERS                                   |   1 +
> >>>  2 files changed, 104 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml
> >>>
> >>
> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> >> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >>
> >> yamllint warnings/errors:
> >>
> >> dtschema/dtc warnings/errors:
> >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected)
> >> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml
> >>
> >> doc reference errors (make refcheckdocs):
> >>
> >> See https://patchwork.ozlabs.org/patch/
> >>
> >> This check can fail if there are any dependencies. The base for a patch
> >> series is generally the most recent rc1.
> >>
> >> If you already ran 'make dt_binding_check' and didn't see the above
> >> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> >> date:
> >>
> >> pip3 install dtschema --upgrade
> >>
> >> Please check and re-submit.
> >>
> > 
> > I run:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Then I check .yaml using:
> > 
> > make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml
> > DTEX    Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dts
> > LINT    Documentation/devicetree/bindings
> > CHKDT   Documentation/devicetree/bindings/processed-schema.json
> > SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> > DTC     Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb
> > CHECK   Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb
> > 
> > No error on my side. I'm missing something?
> 
> Rob's check are running newer dtschema, from master branch. The error he
> reports is about missing port, although I thought it is coming from
> video-interface-devices.

Hi Krzysztof, 
Thanks for the info! :)

Regards,
Tommaso
 
> 
> Best regards,
> Krzysztof

-- 
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________

Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com

  reply	other threads:[~2022-07-13 13:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 16:33 [PATCH v6 0/6] media: ov5693: cleanup code and add dts support Tommaso Merciai
2022-07-12 16:33 ` [PATCH v6 1/6] media: ov5693: count num_supplies using array_size Tommaso Merciai
2022-07-12 16:33 ` [PATCH v6 2/6] media: ov5693: add dvdd into ov5693_supply_names array Tommaso Merciai
2022-07-12 16:33 ` [PATCH v6 3/6] media: ov5693: rename clk into xvclk Tommaso Merciai
2022-07-12 16:33 ` [PATCH v6 4/6] media: ov5693: add support for acpi clock-frequency prop Tommaso Merciai
2022-07-12 16:33 ` [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding Tommaso Merciai
2022-07-12 22:29   ` Rob Herring
2022-07-13  6:48     ` Tommaso Merciai
2022-07-13  6:52       ` Krzysztof Kozlowski
2022-07-13 13:24         ` Tommaso Merciai [this message]
2022-07-13 14:35           ` Sakari Ailus
2022-07-13 15:06             ` Tommaso Merciai
2022-07-12 16:33 ` [PATCH v6 6/6] media: ov5693: add ov5693_of_match, dts support Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713132451.GA1725944@tom-ThinkPad-T14s-Gen-2i \
    --to=tommaso.merciai@amarulasolutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djrscally@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxfancy@googlegroups.com \
    --cc=mchehab@kernel.org \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®