mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bard Liao <yung-chuan.liao@linux.intel.com>
To: alsa-devel@alsa-project.org, vkoul@kernel.org
Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
	tiwai@suse.de, broonie@kernel.org,
	pierre-louis.bossart@linux.intel.com, bard.liao@intel.com
Subject: [PATCH 0/4] ASoC/soundwire: log actual PING status on resume issues
Date: Thu, 14 Jul 2022 09:10:39 +0800	[thread overview]
Message-ID: <20220714011043.46059-1-yung-chuan.liao@linux.intel.com> (raw)

we've been stuck with problems in the dual-amplifier configurations where
one of the two devices seems to become UNATTACHED and never regains sync,
see https://github.com/thesofproject/linux/issues/3638.

This is a rather infrequent issue that may happen once or twice per month,
but still it remains a concern.

One possibility is that the device does lose sync but somehow our hardware
detection fails to see it resync.

This series just adds a basic read directly from the PING frames to help
confirm if yes/no the device regain sync.

The change is mainly on soundwire. @Mark, Could you ack the ASoC patch
if it looks good to you?

Pierre-Louis Bossart (4):
  soundwire: add read_ping_status helper definition in manager ops
  soundwire: intel/cadence: expose PING status in manager ops
  soundwire: add sdw_show_ping_status() helper
  ASoC: codecs: show PING status on resume failures

 drivers/soundwire/bus.c            | 32 ++++++++++++++++++++++++++++++
 drivers/soundwire/cadence_master.c |  8 ++++++++
 drivers/soundwire/cadence_master.h |  2 ++
 drivers/soundwire/intel.c          |  1 +
 include/linux/soundwire/sdw.h      |  5 +++++
 sound/soc/codecs/max98373-sdw.c    |  2 ++
 sound/soc/codecs/rt1308-sdw.c      |  2 ++
 sound/soc/codecs/rt1316-sdw.c      |  2 ++
 sound/soc/codecs/rt5682-sdw.c      |  2 ++
 sound/soc/codecs/rt700-sdw.c       |  2 ++
 sound/soc/codecs/rt711-sdca-sdw.c  |  2 ++
 sound/soc/codecs/rt715-sdca-sdw.c  |  2 ++
 sound/soc/codecs/rt715-sdw.c       |  2 ++
 13 files changed, 64 insertions(+)

-- 
2.25.1


             reply	other threads:[~2022-07-14  1:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  1:10 Bard Liao [this message]
2022-07-14  1:10 ` [PATCH 1/4] soundwire: add read_ping_status helper definition in manager ops Bard Liao
2022-07-14  1:10 ` [PATCH 2/4] soundwire: intel/cadence: expose PING status " Bard Liao
2022-07-14  1:10 ` [PATCH 3/4] soundwire: add sdw_show_ping_status() helper Bard Liao
2022-07-14  1:10 ` [PATCH 4/4] ASoC: codecs: show PING status on resume failures Bard Liao
2022-07-14 19:21   ` Mark Brown
2022-07-18  5:43     ` Vinod Koul
2022-07-18  5:45 ` [PATCH 0/4] ASoC/soundwire: log actual PING status on resume issues Vinod Koul
2022-08-17  6:48   ` Liao, Bard
2022-08-17 11:40     ` Mark Brown
2022-08-17 14:31 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220714011043.46059-1-yung-chuan.liao@linux.intel.com \
    --to=yung-chuan.liao@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®