From: Pratyush Yadav <p.yadav@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <vaishnav.a@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <vigneshr@ti.com>
Subject: Re: [PATCH -next] spi: cadence-quadspi: Remove spi_master_put() in probe failure path
Date: Thu, 14 Jul 2022 16:37:49 +0530 [thread overview]
Message-ID: <20220714110749.ee5r4hznjn3ij66s@ti.com> (raw)
In-Reply-To: <165459880689.302078.15844858048042907353.b4-ty@kernel.org>
Hi Mark,
On 07/06/22 11:46AM, Mark Brown wrote:
> On Wed, 1 Jun 2022 12:46:11 +0530, Vaishnav Achath wrote:
> > Currently the spi_master is allocated by devm_spi_alloc_master()
> > and devres core manages the deallocation, but in probe failure
> > path spi_master_put() is being handled manually which causes
> > "refcount underflow use-after-free" warning when probe failure happens
> > after allocating spi_master.
> >
> > Trimmed backtrace during failure:
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
I see this error in v5.19-rc6 as well. Can we get this patch merged as a
fix in rc7? Sorry for spotting this so late in the cycle, but I thought
you had already got this merged in one of the rcs.
>
> Thanks!
>
> [1/1] spi: cadence-quadspi: Remove spi_master_put() in probe failure path
> commit: 8523c96894e916b20ba3612e48e404fad5acfdd9
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
next prev parent reply other threads:[~2022-07-14 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:16 Vaishnav Achath
2022-06-07 10:46 ` Mark Brown
2022-07-14 11:07 ` Pratyush Yadav [this message]
2022-07-14 13:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714110749.ee5r4hznjn3ij66s@ti.com \
--to=p.yadav@ti.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®