From: Ian Rogers <irogers@google.com>
To: John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Kan Liang <kan.liang@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v1 00/15] Compress the pmu_event tables
Date: Thu, 14 Jul 2022 23:36:38 -0700 [thread overview]
Message-ID: <20220715063653.3203761-1-irogers@google.com> (raw)
jevents.py creates a number of large arrays from the json events. The
arrays contain pointers to strings that need relocating. The
relocations have file size, run time and memory costs. These changes
refactor the pmu_events API so that the storage of the pmu_event
struct isn't exposed. The format is then changed to an offset within a
combined big string, with adjacent pmu_event struct variables being
next to each other in the string separated by \0 - meaning only the
first variable of the struct needs its offset recording.
Some related fixes are contained with the patches. The architecture
jevents.py creates tables for can now be set by the JEVENTS_ARCH make
variable, with a new 'all' that generates the events and metrics for
all architectures.
An example of the improvement to the file size on x86 is:
no jevents - the same 19,579,104bytes
x86 jevents - ~12.5% file size saving 22,088,944bytes vs 25,235,048bytes
all jevents - ~15.8% file size saving 22,821,896bytes vs 27,106,648bytes
default build options plus NO_LIBBFD=1.
I originally suggested fixing this problem in:
https://lore.kernel.org/linux-perf-users/CAP-5=fVB8G4bdb9T=FncRTh9oBVKCS=+=eowAO+YSgAhab+Dtg@mail.gmail.com/
Ian Rogers (15):
perf jevents: Simplify generation of C-string
perf jevents: Add JEVENTS_ARCH make option
perf jevent: Add an 'all' architecture argument
perf jevents: Remove the type/version variables
perf jevents: Provide path to json file on error
perf jevents: Sort json files entries
perf pmu-events: Hide pmu_sys_event_tables
perf pmu-events: Avoid passing pmu_events_map
perf pmu-events: Hide pmu_events_map
perf test: Use full metric resolution
perf pmu-events: Move test events/metrics to json
perf pmu-events: Don't assume pmu_event is an array
perf pmu-events: Hide the pmu_events
perf metrics: Copy entire pmu_event in find metric
perf jevents: Compress the pmu_events_table
tools/perf/arch/arm64/util/pmu.c | 4 +-
tools/perf/pmu-events/Build | 6 +-
.../arch/test/test_soc/cpu/metrics.json | 64 +++
tools/perf/pmu-events/empty-pmu-events.c | 204 +++++++-
tools/perf/pmu-events/jevents.py | 478 ++++++++++++++----
tools/perf/pmu-events/pmu-events.h | 40 +-
tools/perf/tests/expand-cgroup.c | 25 +-
tools/perf/tests/parse-metric.c | 77 +--
tools/perf/tests/pmu-events.c | 466 +++++++----------
tools/perf/util/metricgroup.c | 275 ++++++----
tools/perf/util/metricgroup.h | 5 +-
tools/perf/util/pmu.c | 139 ++---
tools/perf/util/pmu.h | 8 +-
tools/perf/util/s390-sample-raw.c | 50 +-
14 files changed, 1128 insertions(+), 713 deletions(-)
create mode 100644 tools/perf/pmu-events/arch/test/test_soc/cpu/metrics.json
--
2.37.0.170.g444d1eabd0-goog
next reply other threads:[~2022-07-15 6:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 6:36 Ian Rogers [this message]
2022-07-15 6:36 ` [PATCH v1 01/15] perf jevents: Simplify generation of C-string Ian Rogers
2022-07-15 6:36 ` [PATCH v1 02/15] perf jevents: Add JEVENTS_ARCH make option Ian Rogers
2022-07-15 6:36 ` [PATCH v1 03/15] perf jevent: Add an 'all' architecture argument Ian Rogers
2022-07-15 6:36 ` [PATCH v1 04/15] perf jevents: Remove the type/version variables Ian Rogers
2022-07-15 6:36 ` [PATCH v1 05/15] perf jevents: Provide path to json file on error Ian Rogers
2022-07-15 6:36 ` [PATCH v1 06/15] perf jevents: Sort json files entries Ian Rogers
2022-07-15 6:36 ` [PATCH v1 07/15] perf pmu-events: Hide pmu_sys_event_tables Ian Rogers
2022-07-15 6:36 ` [PATCH v1 08/15] perf pmu-events: Avoid passing pmu_events_map Ian Rogers
2022-07-15 6:36 ` [PATCH v1 09/15] perf pmu-events: Hide pmu_events_map Ian Rogers
2022-07-15 6:36 ` [PATCH v1 10/15] perf test: Use full metric resolution Ian Rogers
2022-07-15 6:36 ` [PATCH v1 11/15] perf pmu-events: Move test events/metrics to json Ian Rogers
2022-07-15 6:36 ` [PATCH v1 12/15] perf pmu-events: Don't assume pmu_event is an array Ian Rogers
2022-07-15 6:36 ` [PATCH v1 13/15] perf pmu-events: Hide the pmu_events Ian Rogers
2022-07-15 6:36 ` [PATCH v1 14/15] perf metrics: Copy entire pmu_event in find metric Ian Rogers
2022-07-15 6:36 ` [PATCH v1 15/15] perf jevents: Compress the pmu_events_table Ian Rogers
2022-07-27 4:04 ` Namhyung Kim
2022-07-27 4:53 ` Ian Rogers
2022-07-27 23:20 ` Namhyung Kim
2022-07-27 23:44 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715063653.3203761-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=will@kernel.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®