From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D4EC433EF for ; Fri, 15 Jul 2022 20:43:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbiGOUnR (ORCPT ); Fri, 15 Jul 2022 16:43:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbiGOUmv (ORCPT ); Fri, 15 Jul 2022 16:42:51 -0400 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D9B88CF7 for ; Fri, 15 Jul 2022 13:42:46 -0700 (PDT) Received: by mail-pg1-x549.google.com with SMTP id 79-20020a630252000000b004125da7d520so3249854pgc.11 for ; Fri, 15 Jul 2022 13:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=+qR0uj9gXOWol3Ut+s7ac3HzpVaWBG1IEuybUOvSxq0=; b=C6KjJiMxfi6TfcrSpg7drl9YK/LsDK/v8OH6X3SiR6jz1s3rb8YHxjWdg+OXmFsAUu vWh0XYxH4JUpfIcLDuduYIGX2oOus0G/7WQ6R8FfzoiYl+4Qnm2mYw00V4FgPoSU96qx /OKP3S/kpJxqEJa90NwGgTedyifKoIWLiZotp8jZfG85+90TEDZZMKiwOShsF0QOESKW IUFv4fe41b2FSsV5zovagvyDLC3p46xp8f47/OpL2QrXNF6vv8mAJ4sdCrzIiDutbsx1 FlU7gDbBgDI5wKcB5U6f0L7qlp+nzMnBAeYbdLahJHOvoXWBqGzQ/yMTj6/S1kyUoRKL GPqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=+qR0uj9gXOWol3Ut+s7ac3HzpVaWBG1IEuybUOvSxq0=; b=qZ5Cr9kGCqR07v/oJ5EN1iOg8hjPgy4WpMvEo+R6VflG2un1OGVfalol1tAbNVYri3 117wiYV0n9Eu06GUm+C71hSr562QUYJ4b3HRD2eITsDEe4pSGL1hI73+2Q8XOJsKUO7c lYAqAA0Q4twNnjSui9Io8APXyUl+mVuydn6SAoIicL0Mnsnft7lrT9bOCOCWJN6+MC0w 1j+8l/pH/fZ4HevIW9iwKJkK/4iqjAUYYBAEkgitGnhz4o28hByaeSIZACPME9L1kuo7 agSBR59x0BQq9AnYp+oFHM3AVEpFiJE6YV4PI0kazYdJs+0QJR1FhVMFAwB6PE24nS3Q 24zw== X-Gm-Message-State: AJIora8V9Doxtmbjn+IO6dogzaeoXVueLpH/xEQ3XF3Kfd4E7OiYRhf1 Y0Cp2HA9HfFooXFXzSy1b/5fB6/yckc= X-Google-Smtp-Source: AGRyM1u6kpeizk0sTrx9oLthKLn2xlFlo/YmGOxFoXKdKdg+H6gNEeavaMLO/1TsQ+Hb3EMEGoPBKMPdG2A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:17aa:b0:52a:e94b:67e5 with SMTP id s42-20020a056a0017aa00b0052ae94b67e5mr15999481pfg.76.1657917765969; Fri, 15 Jul 2022 13:42:45 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 15 Jul 2022 20:42:09 +0000 In-Reply-To: <20220715204226.3655170-1-seanjc@google.com> Message-Id: <20220715204226.3655170-8-seanjc@google.com> Mime-Version: 1.0 References: <20220715204226.3655170-1-seanjc@google.com> X-Mailer: git-send-email 2.37.0.170.g444d1eabd0-goog Subject: [PATCH v2 07/24] KVM: x86: Use DR7_GD macro instead of open coding check in emulator From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , Maxim Levitsky , Oliver Upton , Peter Shier Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DR7_GD in the emulator instead of open coding the check, and drop a comically wrong comment. Signed-off-by: Sean Christopherson Reviewed-by: Maxim Levitsky --- arch/x86/kvm/emulate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index bd9e9c5627d0..fdeccf446b28 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -4181,8 +4181,7 @@ static int check_dr7_gd(struct x86_emulate_ctxt *ctxt) ctxt->ops->get_dr(ctxt, 7, &dr7); - /* Check if DR7.Global_Enable is set */ - return dr7 & (1 << 13); + return dr7 & DR7_GD; } static int check_dr_read(struct x86_emulate_ctxt *ctxt) -- 2.37.0.170.g444d1eabd0-goog