Hi Konrad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/irq/core] [also build test WARNING on robh/for-next linus/master v5.19-rc6 next-20220714] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/dt-bindings-apple-aic-Document-A7-A11-compatibles/20220713-001059 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ac165aab469895de059a4a191a2e04ddb5421d0e config: arm64-randconfig-r014-20220715 compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 2da550140aa98cf6a3e96417c87f1e89e3a26047) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/afa007835ace3d280cbc9aed6b1a1c8a1acd3275 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Konrad-Dybcio/dt-bindings-apple-aic-Document-A7-A11-compatibles/20220713-001059 git checkout afa007835ace3d280cbc9aed6b1a1c8a1acd3275 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/irqchip/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/irqchip/irq-apple-aic.c:700:4: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ drivers/irqchip/irq-apple-aic.c:700:4: note: insert 'break;' to avoid fall-through default: ^ break; 1 warning generated. vim +700 drivers/irqchip/irq-apple-aic.c 76cde26394114f6 Hector Martin 2021-01-21 648 76cde26394114f6 Hector Martin 2021-01-21 649 static int aic_irq_domain_translate(struct irq_domain *id, 76cde26394114f6 Hector Martin 2021-01-21 650 struct irq_fwspec *fwspec, 76cde26394114f6 Hector Martin 2021-01-21 651 unsigned long *hwirq, 76cde26394114f6 Hector Martin 2021-01-21 652 unsigned int *type) 76cde26394114f6 Hector Martin 2021-01-21 653 { 76cde26394114f6 Hector Martin 2021-01-21 654 struct aic_irq_chip *ic = id->host_data; a801f0ee563b818 Hector Martin 2022-03-10 655 u32 *args; a801f0ee563b818 Hector Martin 2022-03-10 656 u32 die = 0; 76cde26394114f6 Hector Martin 2021-01-21 657 a801f0ee563b818 Hector Martin 2022-03-10 658 if (fwspec->param_count < 3 || fwspec->param_count > 4 || a801f0ee563b818 Hector Martin 2022-03-10 659 !is_of_node(fwspec->fwnode)) 76cde26394114f6 Hector Martin 2021-01-21 660 return -EINVAL; 76cde26394114f6 Hector Martin 2021-01-21 661 a801f0ee563b818 Hector Martin 2022-03-10 662 args = &fwspec->param[1]; a801f0ee563b818 Hector Martin 2022-03-10 663 a801f0ee563b818 Hector Martin 2022-03-10 664 if (fwspec->param_count == 4) { a801f0ee563b818 Hector Martin 2022-03-10 665 die = args[0]; a801f0ee563b818 Hector Martin 2022-03-10 666 args++; a801f0ee563b818 Hector Martin 2022-03-10 667 } a801f0ee563b818 Hector Martin 2022-03-10 668 76cde26394114f6 Hector Martin 2021-01-21 669 switch (fwspec->param[0]) { 76cde26394114f6 Hector Martin 2021-01-21 670 case AIC_IRQ: a801f0ee563b818 Hector Martin 2022-03-10 671 if (die >= ic->nr_die) 76cde26394114f6 Hector Martin 2021-01-21 672 return -EINVAL; a801f0ee563b818 Hector Martin 2022-03-10 673 if (args[0] >= ic->nr_irq) 76cde26394114f6 Hector Martin 2021-01-21 674 return -EINVAL; a801f0ee563b818 Hector Martin 2022-03-10 675 *hwirq = AIC_IRQ_HWIRQ(die, args[0]); 76cde26394114f6 Hector Martin 2021-01-21 676 break; 76cde26394114f6 Hector Martin 2021-01-21 677 case AIC_FIQ: a801f0ee563b818 Hector Martin 2022-03-10 678 if (die != 0) 76cde26394114f6 Hector Martin 2021-01-21 679 return -EINVAL; a801f0ee563b818 Hector Martin 2022-03-10 680 if (args[0] >= AIC_NR_FIQ) 76cde26394114f6 Hector Martin 2021-01-21 681 return -EINVAL; a801f0ee563b818 Hector Martin 2022-03-10 682 *hwirq = AIC_FIQ_HWIRQ(args[0]); 76cde26394114f6 Hector Martin 2021-01-21 683 76cde26394114f6 Hector Martin 2021-01-21 684 /* 76cde26394114f6 Hector Martin 2021-01-21 685 * In EL1 the non-redirected registers are the guest's, 76cde26394114f6 Hector Martin 2021-01-21 686 * not EL2's, so remap the hwirqs to match. 76cde26394114f6 Hector Martin 2021-01-21 687 */ 76cde26394114f6 Hector Martin 2021-01-21 688 if (!is_kernel_in_hyp_mode()) { a801f0ee563b818 Hector Martin 2022-03-10 689 switch (args[0]) { 76cde26394114f6 Hector Martin 2021-01-21 690 case AIC_TMR_GUEST_PHYS: 7c841f5f6fa3f99 Hector Martin 2022-03-10 691 *hwirq = AIC_FIQ_HWIRQ(AIC_TMR_EL0_PHYS); 76cde26394114f6 Hector Martin 2021-01-21 692 break; 76cde26394114f6 Hector Martin 2021-01-21 693 case AIC_TMR_GUEST_VIRT: 7c841f5f6fa3f99 Hector Martin 2022-03-10 694 *hwirq = AIC_FIQ_HWIRQ(AIC_TMR_EL0_VIRT); 76cde26394114f6 Hector Martin 2021-01-21 695 break; 76cde26394114f6 Hector Martin 2021-01-21 696 case AIC_TMR_HV_PHYS: 76cde26394114f6 Hector Martin 2021-01-21 697 case AIC_TMR_HV_VIRT: afa007835ace3d2 Konrad Dybcio 2022-07-12 698 if (aic_irqc->info.el2_regs) 76cde26394114f6 Hector Martin 2021-01-21 699 return -ENOENT; 76cde26394114f6 Hector Martin 2021-01-21 @700 default: 76cde26394114f6 Hector Martin 2021-01-21 701 break; 76cde26394114f6 Hector Martin 2021-01-21 702 } 76cde26394114f6 Hector Martin 2021-01-21 703 } 76cde26394114f6 Hector Martin 2021-01-21 704 break; 76cde26394114f6 Hector Martin 2021-01-21 705 default: 76cde26394114f6 Hector Martin 2021-01-21 706 return -EINVAL; 76cde26394114f6 Hector Martin 2021-01-21 707 } 76cde26394114f6 Hector Martin 2021-01-21 708 a801f0ee563b818 Hector Martin 2022-03-10 709 *type = args[1] & IRQ_TYPE_SENSE_MASK; 76cde26394114f6 Hector Martin 2021-01-21 710 76cde26394114f6 Hector Martin 2021-01-21 711 return 0; 76cde26394114f6 Hector Martin 2021-01-21 712 } 76cde26394114f6 Hector Martin 2021-01-21 713 -- 0-DAY CI Kernel Test Service https://01.org/lkp