From: Andrew Morton <akpm@linux-foundation.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Gavin Keusch <gavinkeusch@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: watchdog: fix missing space coding style issue
Date: Sat, 16 Jul 2022 17:37:54 -0700 [thread overview]
Message-ID: <20220716173754.62f9cc348cfa08951770bb0b@linux-foundation.org> (raw)
In-Reply-To: <20220714083149.GC2737@pathway.suse.cz>
On Thu, 14 Jul 2022 10:31:49 +0200 Petr Mladek <pmladek@suse.com> wrote:
> Adding Andrew into Cc who usually takes patches for kernel/watchdog.c.
>
> Best Regards,
> Petr
>
> On Wed 2022-07-13 23:04:57, Gavin Keusch wrote:
> > Fixed missing space causing coding style error
> >
> > Signed-off-by: Gavin Keusch <gavinkeusch@gmail.com>
> > ---
> > kernel/watchdog.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> > index ecb0e8346e65..b6b150c4b179 100644
> > --- a/kernel/watchdog.c
> > +++ b/kernel/watchdog.c
> > @@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
> > unsigned long period_ts,
> > unsigned long now)
> > {
> > - if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
> > + if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
> > /* Warn about unreasonable delays. */
> > if (time_after(now, period_ts + get_softlockup_thresh()))
> > return now - touch_ts;
Patch is too minor to justify merging, sorry. If it fixed 15
coding-style errors then maybe. But this way just leads to too much
noise.
prev parent reply other threads:[~2022-07-17 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 6:04 Gavin Keusch
2022-07-14 8:31 ` Petr Mladek
2022-07-17 0:37 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220716173754.62f9cc348cfa08951770bb0b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gavinkeusch@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®