From: Andrey Strachuk <strochuk@ispras.ru>
To: Tero Kristo <kristo@kernel.org>
Cc: Andrey Strachuk <strochuk@ispras.ru>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Tony Lindgren <tony@atomide.com>,
Colin Ian King <colin.i.king@googlemail.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: [PATCH] clk/ti/adpll: remove useless comparison in ti_adpll_free_resources()
Date: Tue, 19 Jul 2022 13:23:19 +0300 [thread overview]
Message-ID: <20220719102319.5912-1-strochuk@ispras.ru> (raw)
Local variable 'ac' is initialized by an address
of field of ti_adpll_data, so it does not make
sense to compare 'ac' with NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
Fixes: 21330497f303 ("clk: ti: Add support for dm814x ADPLL")
---
drivers/clk/ti/adpll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index 962502ca7ff0..7207915f9440 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -772,7 +772,7 @@ static void ti_adpll_free_resources(struct ti_adpll_data *d)
for (i = TI_ADPLL_M3; i >= 0; i--) {
struct ti_adpll_clock *ac = &d->clocks[i];
- if (!ac || IS_ERR_OR_NULL(ac->clk))
+ if (IS_ERR_OR_NULL(ac->clk))
continue;
if (ac->cl)
clkdev_drop(ac->cl);
--
2.25.1
reply other threads:[~2022-07-19 10:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719102319.5912-1-strochuk@ispras.ru \
--to=strochuk@ispras.ru \
--cc=colin.i.king@googlemail.com \
--cc=kristo@kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®