From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F0BC43334 for ; Tue, 19 Jul 2022 15:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238128AbiGSPFa (ORCPT ); Tue, 19 Jul 2022 11:05:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239043AbiGSPFT (ORCPT ); Tue, 19 Jul 2022 11:05:19 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 953F133E for ; Tue, 19 Jul 2022 08:05:18 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC52813D5; Tue, 19 Jul 2022 08:05:18 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3948A3F70D; Tue, 19 Jul 2022 08:05:16 -0700 (PDT) Date: Tue, 19 Jul 2022 16:05:13 +0100 From: Sudeep Holla To: Conor Dooley Cc: Geert Uytterhoeven , Sudeep Holla , Linux Kernel Mailing List , Greg Kroah-Hartman , Conor Dooley , valentina.fernandezalanis@microchip.com, Vincent Guittot , Dietmar Eggemann , Qing Wang , Rob Herring , "Rafael J . Wysocki" , Ionela Voinescu , Pierre Gondois , Linux ARM , linux-riscv , Gavin Shan Subject: Re: [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes Message-ID: <20220719150513.a525arh663qlhkob@bogus> References: <20220704101605.1318280-1-sudeep.holla@arm.com> <20220704101605.1318280-10-sudeep.holla@arm.com> <73f9d00c-b64c-7c70-c49f-99d3894fad24@conchuod.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73f9d00c-b64c-7c70-c49f-99d3894fad24@conchuod.ie> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 03:37:22PM +0100, Conor Dooley wrote: > On 19/07/2022 15:22, Geert Uytterhoeven wrote: > > Hi Sudeep, > > > > Hey Geert, > [...] > > > > This is triggered > > > > Early cacheinfo failed, ret = -12 > > > > on all my RV64 platforms (K210, PolarFire, StarLight). > > This should be fixed by Sudeeps most recent patchset, at least > it was when I tested it! > https://lore.kernel.org/all/20220713133344.1201247-1-sudeep.holla@arm.com/ > Conor you beat me in the response speed :). > > -12 = -ENOMEM. > > > > The boot continues regardless, and the K210 even has enough spare > > RAM after boot to run "ls", unlike two weeks ago ;-) > > Yes Conor initially reported this and I suspected something to do with per-cpu allocation as the early cacheinfo failed but succeeded in device initcall level. However when fixing some hotplug issue, I moved the detection of cache attributes on all cpus from boot cpu to individual CPUs in the secondary startup which seem to fix the issue as I assume the per-cpu allocation is ready to use at that stage. However we still have one pending issue[0] to address even after [1], but that doesn't affect DT platforms. -- Regards, Sudeep [0] https://lore.kernel.org/all/20220718174151.GA462603@roeck-us.net/ [1] https://lore.kernel.org/all/20220715102609.2160689-1-sudeep.holla@arm.com/