From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E171CCA487 for ; Wed, 20 Jul 2022 01:23:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240852AbiGTBXL (ORCPT ); Tue, 19 Jul 2022 21:23:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240768AbiGTBNg (ORCPT ); Tue, 19 Jul 2022 21:13:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 475914BD0C; Tue, 19 Jul 2022 18:12:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA25A61729; Wed, 20 Jul 2022 01:12:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81905C36AE2; Wed, 20 Jul 2022 01:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658279562; bh=QHWe2S8lwDPE8S3hDWLi4CUyziW6FUFYG7Yw541+8o0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lPzNBoIn5EvzUnH8AzUBGdbvw9zgqG32PhHzCL6TqoACUk72KGVJt8V0bTYkWQoxg sHZvbKQ152RIj7RX5FzITuPyTLoH25tsJ8aOIbpnoQA6VsEJhQ4U3A90nAE07KetOY EgirztPaB9ubIEDMI6fSAnFt7cD9h1hPWqMHflNIG2SHawZ4Wbtpdk7huhyURCYLvP qNQkDbPke8rnYOT+RJvfZzy8rGHaB2XajyOENNEPr27GLR2XtzCYJ4+efonAksFQ7U Snz66E6g5HKm5e8+uSjYyfNz3wnFTMrUGFVF33kkycZFXHbuqccbVygO0ESLNwwNhK mwhOUmL37g15Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ryusuke Konishi , Tommy Pettersson , Ciprian Craciun , Andrew Morton , Sasha Levin , linux-nilfs@vger.kernel.org Subject: [PATCH AUTOSEL 5.18 33/54] nilfs2: fix incorrect masking of permission flags for symlinks Date: Tue, 19 Jul 2022 21:10:10 -0400 Message-Id: <20220720011031.1023305-33-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220720011031.1023305-1-sashal@kernel.org> References: <20220720011031.1023305-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ryusuke Konishi [ Upstream commit 5924e6ec1585445f251ea92713eb15beb732622a ] The permission flags of newly created symlinks are wrongly dropped on nilfs2 with the current umask value even though symlinks should have 777 (rwxrwxrwx) permissions: $ umask 0022 $ touch file && ln -s file symlink; ls -l file symlink -rw-r--r--. 1 root root 0 Jun 23 16:29 file lrwxr-xr-x. 1 root root 4 Jun 23 16:29 symlink -> file This fixes the bug by inserting a missing check that excludes symlinks. Link: https://lkml.kernel.org/r/1655974441-5612-1-git-send-email-konishi.ryusuke@gmail.com Signed-off-by: Ryusuke Konishi Reported-by: Tommy Pettersson Reported-by: Ciprian Craciun Tested-by: Ryusuke Konishi Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/nilfs2/nilfs.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/nilfs2/nilfs.h b/fs/nilfs2/nilfs.h index 1344f7d475d3..aecda4fc95f5 100644 --- a/fs/nilfs2/nilfs.h +++ b/fs/nilfs2/nilfs.h @@ -198,6 +198,9 @@ static inline int nilfs_acl_chmod(struct inode *inode) static inline int nilfs_init_acl(struct inode *inode, struct inode *dir) { + if (S_ISLNK(inode->i_mode)) + return 0; + inode->i_mode &= ~current_umask(); return 0; } -- 2.35.1