From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
To: fparent@baylibre.com
Cc: iommu@lists.linux-foundation.org, joro@8bytes.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, will@kernel.org, yong.wu@mediatek.com,
Amjad Ouled-Ameur <aouledameur@baylibre.com>
Subject: Re: [PATCH 3/3] iommu: mtk_iommu: add support for MT8365 SoC
Date: Wed, 20 Jul 2022 10:52:13 +0200 [thread overview]
Message-ID: <20220720085213.3803-1-aouledameur@baylibre.com> (raw)
In-Reply-To: <20220530180328.845692-3-fparent@baylibre.com>
Hi Fabien,
Thank you for the fix.
The kernel would panic if you boot with this patchset because
bank_nr and bank_enable are not set in mt8365_data.
Please add this change:
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -1538,6 +1538,8 @@ static const struct mtk_iommu_plat_data mt8365_data = {
.m4u_plat = M4U_MT8365,
.flags = RESET_AXI,
.inv_sel_reg = REG_MMU_INV_SEL_GEN1,
+ .banks_num = 1,
+ .banks_enable = {true},
.iova_region = single_domain,
.iova_region_nr = ARRAY_SIZE(single_domain),
.larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */
With this change, please add my:
Reviewed-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Tested-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Regards,
Amjad
next prev parent reply other threads:[~2022-07-20 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 18:03 [PATCH 1/3] dt-bindings: iommu: mediatek: add binding documentation " Fabien Parent
2022-05-30 18:03 ` [PATCH 2/3] iommu: mtk_iommu: add support for 6-bit encoded port IDs Fabien Parent
2022-06-02 6:18 ` Yong Wu
2022-05-30 18:03 ` [PATCH 3/3] iommu: mtk_iommu: add support for MT8365 SoC Fabien Parent
2022-07-20 8:52 ` Amjad Ouled-Ameur [this message]
2022-06-02 6:18 ` [PATCH 1/3] dt-bindings: iommu: mediatek: add binding documentation " Yong Wu
2022-06-02 8:27 ` Macpaul Lin
2022-06-02 8:42 ` Macpaul Lin
2022-06-02 9:26 ` Yong Wu
2022-06-05 21:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720085213.3803-1-aouledameur@baylibre.com \
--to=aouledameur@baylibre.com \
--cc=fparent@baylibre.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®